Skip to content

Exit after container creation script #34945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Exit after container creation script #34945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .devcontainer/scripts/container-creation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ git submodule update --init --recursive
# Also run the full restore on the repo so that go-to definition
# and other language features will be available in C# files
./restore.sh
# The container creation script is executed in a new Bash instance
# so we exit at the end to avoid the creation process lingering.
exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe my bash is rusty, but don't scripts implicitly exit their host process when they reach the end?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep -- it does. This is more so working around some funkiness with the way Codespaces seems to launch the postCommand script.