Skip to content

[release/3.1] Align CODEOWNERS with 'main' #35950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@
# Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths.
# See https://help.github.com/articles/about-code-owners/

/global.json @aspnet/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔

Sure.

/.azure/ @aspnet/build
/.config/ @aspnet/build
/build/ @aspnet/build
/eng/ @aspnet/build
* @Pilchie
/global.json @dotnet/aspnet-build
/.azure/ @dotnet/aspnet-build
/.config/ @dotnet/aspnet-build
/.github/ @dotnet/aspnet-build
/.github/*_TEMPLATE/ @dotnet/aspnet-build @mkArtakMSFT
/build/ @dotnet/aspnet-build
/eng/ @dotnet/aspnet-build
/eng/common/ @dotnet-maestro-bot
/eng/Versions.props @dotnet-maestro-bot @dougbu
/eng/Version.Details.xml @dotnet-maestro-bot @dougbu
/src/Components/ @SteveSandersonMS
/src/DefaultBuilder/ @tratcher @anurse
/src/Hosting/ @tratcher @anurse
/src/Http/ @tratcher @jkotalik @anurse
/src/Middleware/ @tratcher @anurse
/src/ProjectTemplates/ @ryanbrandenburg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an assignment for this subfolder or lots of /src/ here or in 'main'. Do we need more ownerships❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should address that. @pranavkm for this one?

/src/Security/ @tratcher @anurse
/src/Servers/ @tratcher @jkotalik @anurse @halter73
/src/Middleware/Rewrite @jkotalik @anurse
/src/Middleware/HttpsPolicy @jkotalik @anurse
/src/SignalR/ @BrennanConroy @halter73 @anurse
/src/**/ref/ @dotnet/aspnet-api-review
/src/Components/ @dotnet/aspnet-blazor-eng
/src/DefaultBuilder/ @tratcher
/src/Hosting/ @tratcher
/src/Http/ @tratcher @BrennanConroy
/src/Http/Routing/ @javiercn
/src/Middleware/ @tratcher @BrennanConroy
/src/Mvc/ @pranavkm @javiercn
/src/Security/ @tratcher
/src/Servers/ @tratcher @halter73 @BrennanConroy
/src/SignalR/ @BrennanConroy @halter73
/src/submodules @dotnet/aspnet-build @dougbu @wtgodbe