-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/3.1] Align CODEOWNERS with 'main' #35950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think I requested reviews from most affected people. Feel free to /cc or add reviewers if I missed someone. |
/src/Hosting/ @tratcher @anurse | ||
/src/Http/ @tratcher @jkotalik @anurse | ||
/src/Middleware/ @tratcher @anurse | ||
/src/ProjectTemplates/ @ryanbrandenburg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have an assignment for this subfolder or lots of /src/ here or in 'main'. Do we need more ownerships❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should address that. @pranavkm for this one?
- add and remove many assignments
61598d3
to
eaddf1a
Compare
@@ -1,22 +1,25 @@ | |||
# Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths. | |||
# See https://help.github.com/articles/about-code-owners/ | |||
|
|||
/global.json @aspnet/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔
Sure.
Will rerun once #35636 is in |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is general cleanup but I added a few assignments too.