Skip to content

[release/3.1] Align CODEOWNERS with 'main' #35950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 31, 2021

  • add and remove many assignments

This is general cleanup but I added a few assignments too.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 31, 2021

I think I requested reviews from most affected people. Feel free to /cc or add reviewers if I missed someone.

/src/Hosting/ @tratcher @anurse
/src/Http/ @tratcher @jkotalik @anurse
/src/Middleware/ @tratcher @anurse
/src/ProjectTemplates/ @ryanbrandenburg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an assignment for this subfolder or lots of /src/ here or in 'main'. Do we need more ownerships❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should address that. @pranavkm for this one?

@dougbu dougbu changed the title Align CODEOWNERS with 'main' [release/3.1] Align CODEOWNERS with 'main' Aug 31, 2021
- add and remove many assignments
@dougbu dougbu force-pushed the dougbu/anurse.jkotalik/3.1 branch from 61598d3 to eaddf1a Compare August 31, 2021 00:10
@@ -1,22 +1,25 @@
# Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths.
# See https://help.github.com/articles/about-code-owners/

/global.json @aspnet/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie do you want to own everything as you do in 'release/6.0' and 'main'❔

Sure.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 31, 2021

Will rerun once #35636 is in

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 31, 2021
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 31, 2021
@dougbu
Copy link
Contributor Author

dougbu commented Sep 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dougbu dougbu enabled auto-merge (squash) September 8, 2021 23:19
@wtgodbe wtgodbe added this to the 3.1.20 milestone Sep 9, 2021
@dougbu dougbu merged commit 54786d7 into release/3.1 Sep 9, 2021
@dougbu dougbu deleted the dougbu/anurse.jkotalik/3.1 branch September 9, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants