[release/5.0] Align CODEOWNERS with 'main' #35953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Aug 31, 2021
dougbu
commented
- add and remove many assignments
- mostly match 'main' version less missing directories
- add and remove many assignments - mostly match 'main' version less missing directories
dougbu
requested review from
halter73,
pranavkm,
adityamandaleeka,
SteveSandersonMS,
captainsafia,
javiercn,
BrennanConroy,
mkArtakMSFT,
rafikiassumani-msft and
a team
dougbu
commented
Aug 31, 2021
| /eng/common/ @dotnet-maestro-bot | ||
| /eng/Versions.props @dotnet-maestro-bot @dougbu | ||
| /eng/Version.Details.xml @dotnet-maestro-bot @dougbu | ||
| /src/Components/ @dotnet/aspnet-blazor-eng @SteveSandersonMS |
There was a problem hiding this comment.
@SteveSandersonMS you don't have this separate assignment in 'release/6.0', 'main' or #35950. Is this needed here❔
| /eng/Versions.props @dotnet-maestro-bot @dougbu | ||
| /eng/Version.Details.xml @dotnet-maestro-bot @dougbu | ||
| /src/Components/ @dotnet/aspnet-blazor-eng @SteveSandersonMS | ||
| /src/Components/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @dotnet/aspnet-blazor-eng |
There was a problem hiding this comment.
Seems we totally missed including @dotnet/aspnet-api-review for these files in this branch
| @@ -1,27 +1,40 @@ | |||
| # Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths. | |||
| # See https://help.github.com/articles/about-code-owners/ | |||
|
|
|||
| /global.json @aspnet/build | |||
| /src/Middleware/ @tratcher | ||
| /src/Middleware/HttpsPolicy/ @jkotalik | ||
| /src/Middleware/Rewrite/ @jkotalik | ||
| # /src/ProjectTemplates/ @ryanbrandenburg |
There was a problem hiding this comment.
Same question (I guess to leads) about filling in src/* gaps as in #35950
Pilchie
added
the
area-infrastructure
|
Will rerun once #35637 is in |
wtgodbe
approved these changes
Sep 1, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.