Skip to content

[release/5.0] Align CODEOWNERS with 'main' #35953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 37 additions & 23 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,27 +1,41 @@
# Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths.
# See https://help.github.com/articles/about-code-owners/

/global.json @aspnet/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie same question here as in #35950 about you owning the world

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie same question here as in #35950 about you owning the world

Fine with me.

/.azure/ @aspnet/build
/.config/ @aspnet/build
/build/ @aspnet/build
/eng/ @aspnet/build
/eng/common/ @dotnet-maestro-bot
/eng/Versions.props @dotnet-maestro-bot @dougbu
/eng/Version.Details.xml @dotnet-maestro-bot @dougbu
/src/Components/ @SteveSandersonMS @dotnet/aspnet-blazor-eng
/src/DefaultBuilder/ @tratcher
/src/Hosting/ @tratcher
/src/Http/ @tratcher @jkotalik
/src/Http/Routing/ @javiercn
/src/Middleware/ @tratcher
/src/Middleware/HttpsPolicy/ @jkotalik
/src/Middleware/Rewrite/ @jkotalik
# /src/ProjectTemplates/ @ryanbrandenburg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question (I guess to leads) about filling in src/* gaps as in #35950

/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/ @dotnet/aspnet-blazor-eng
* @Pilchie
/global.json @dotnet/aspnet-build
/.azure/ @dotnet/aspnet-build
/.config/ @dotnet/aspnet-build
/.devcontainer/ @captainsafia
/.github/ @dotnet/aspnet-build
/.github/*_TEMPLATE/ @dotnet/aspnet-build @mkArtakMSFT
/.github/workflows/ @dotnet/aspnet-build @tratcher
/docs/ @captainsafia @mkArtakMSFT
/eng/ @dotnet/aspnet-build
/eng/common/ @dotnet-maestro-bot
/eng/Versions.props @dotnet-maestro-bot @dougbu
/eng/Version.Details.xml @dotnet-maestro-bot @dougbu
/src/Components/ @dotnet/aspnet-blazor-eng @SteveSandersonMS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveSandersonMS you don't have this separate assignment in 'release/6.0', 'main' or #35950. Is this needed here❔

/src/Components/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @dotnet/aspnet-blazor-eng
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we totally missed including @dotnet/aspnet-api-review for these files in this branch☹️

/src/DefaultBuilder/ @tratcher
/src/DefaultBuilder/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher
/src/Hosting/ @tratcher
/src/Hosting/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher
/src/Http/ @tratcher @BrennanConroy
/src/Http/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher @BrennanConroy
/src/Http/Routing/ @javiercn
/src/Http/Routing/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @javiercn
/src/Middleware/ @tratcher @BrennanConroy
/src/Middleware/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher @BrennanConroy
/src/Mvc/ @pranavkm @javiercn
/src/Mvc/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @pranavkm @javiercn
/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/ @dotnet/aspnet-blazor-eng
/src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/ @dotnet/aspnet-blazor-eng
/src/Security/ @tratcher
/src/Servers/ @tratcher @jkotalik @halter73
/src/Shared/runtime/ @dotnet/http
/src/Shared/test/Shared.Tests/runtime/ @dotnet/http
/src/SignalR/ @BrennanConroy @halter73
/src/Security/ @tratcher
/src/Security/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher
/src/Servers/ @tratcher @halter73 @BrennanConroy
/src/Servers/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @tratcher @halter73 @BrennanConroy
/src/Shared/runtime/ @dotnet/http
/src/Shared/test/Shared.Tests/runtime/ @dotnet/http
/src/SignalR/ @BrennanConroy @halter73
/src/SignalR/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @BrennanConroy @halter73
/src/submodules @dotnet/aspnet-build @dougbu @wtgodbe