Skip to content

[main] Update WiX to signed build #37317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Oct 6, 2021
Merged

[main] Update WiX to signed build #37317

2 commits merged into from
Oct 6, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2021

Backport of #36865 to main

/cc @ericstj @dougbu

@github-actions github-actions bot requested a review from a team as a code owner October 6, 2021 04:54
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 6, 2021
@ghost
Copy link

ghost commented Oct 6, 2021

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ericstj ericstj requested a review from BrennanConroy October 6, 2021 04:56
@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

At one point, @joeloff said we should wait to change main until all necessary changes were in Microsoft.Signed.WiX. Are we at that point now❔

Suggest we should include the fix for #37290 in this PR.

@joeloff
Copy link
Member

joeloff commented Oct 6, 2021

At one point, @joeloff said we should wait to change main until all necessary changes were in Microsoft.Signed.WiX. Are we at that point now❔

Suggest we should include the fix for #37290 in this PR.

You could just just jump to 5722 for main. As I mentioned on another issue, there's a corresponding authoring change as well to leverage a new property in the 5722 build. You can take them separately or together

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

Ok, I went ahead and added that change here.

@ghost ghost merged commit 4adf8f3 into main Oct 6, 2021
@ghost ghost deleted the backport/pr-36865-to-main branch October 6, 2021 07:31
@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

/backport to release/6.0

@ghost
Copy link

ghost commented Oct 6, 2021

Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 6, 2021

@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

Thanks @ericstj and your bot friend❕

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

Double backport FTW

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants