Skip to content

Update Microsoft.Signed.WiX to 1.0.0-v3.14.0.5722 #37290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joeloff opened this issue Oct 5, 2021 · 9 comments · Fixed by #37335
Closed

Update Microsoft.Signed.WiX to 1.0.0-v3.14.0.5722 #37290

joeloff opened this issue Oct 5, 2021 · 9 comments · Fixed by #37335
Assignees
@dougbu
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@joeloff
Copy link
Member

joeloff commented Oct 5, 2021

Updated WiX build that contains changes to better support x64 emulation on arm64. This is needed for 6.0.
@joeloff
Copy link
Member Author

joeloff commented Oct 5, 2021

@wtgodbe

@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 5, 2021
@BrennanConroy
Copy link
Member

@dougbu since Will is out

@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

@joeloff how is 5722 different from 4118❔

@dougbu dougbu self-assigned this Oct 6, 2021
@dougbu dougbu mentioned this issue Oct 6, 2021
Merged
@joeloff
Copy link
Member Author

joeloff commented Oct 6, 2021 •
edited
Loading

For RC2 setting up the PROCESSOR_ARCHITECTURE property was authored into each MSI manually and based off a registry key. That logic has been moved into a custom action that's part of WiX and calls into IsWow64Process2 which is preferable. It also means we don't risk making a mistake copying the registry logic around in repos since we can just reference the property. There will be a second round of changes for the setup authoring

This was referenced Oct 6, 2021
Merged
Merged
@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021 •
edited
Loading

I think we're done w/ the original request wording but not with the intent. That is,

Agreed @joeloff @ericstj❔

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021 •
edited
Loading

The last two are not tracked in this issue. I'm planning to take those separately for tactics approval. (along with arcade and installer changes that are also required).

This can be closed now that the wix update is in main and release.

@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

The last two are not tracked in this issue

Yes and no. I'd rather close this later today when #37335 is in. From the Tactics conversation, it's fairly clear we want both the new WiX version and the WIX_NATIVE_MACHINE change.

@dougbu dougbu linked a pull request Oct 6, 2021 that will close this issue
[release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine #37335
Merged
@dougbu dougbu mentioned this issue Oct 6, 2021
Merged
dougbu pushed a commit that referenced this issue Oct 6, 2021
@github-actions @ericstj
[release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of…
2fddf68 
… target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>
ericstj added a commit to ericstj/aspnetcore that referenced this issue Oct 8, 2021
@github-actions @ericstj
[release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of…
5c5f9a0 
… target machine (dotnet#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in dotnet#37290

Co-authored-by: Eric StJohn <[email protected]>
ericstj added a commit to ericstj/aspnetcore that referenced this issue Oct 8, 2021
@github-actions @ericstj
[release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of…
d87d0d6 
… target machine (dotnet#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in dotnet#37290

Co-authored-by: Eric StJohn <[email protected]>
@dougbu
Copy link
Contributor

dougbu commented Oct 8, 2021 •
edited by wtgodbe
Loading

Backport PRs are open; might as well track them here too

dougbu added a commit that referenced this issue Oct 11, 2021
@ericstj @github-actions @dougbu
[release/5.0] Backport x64 on ARM64 installer changes (#37407)
b3238fb 
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
dougbu added a commit that referenced this issue Oct 11, 2021
@ericstj @github-actions @dougbu
[release/3.1] Backport x64 on ARM64 installer changes (#37409)
730a662 
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
@wtgodbe
Copy link
Member

wtgodbe commented Oct 19, 2021

Closing this since all linked PRs are merged, @dougbu please re-open if I'm mistaken.

@wtgodbe wtgodbe closed this as completed Oct 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
6 participants
@dougbu @javiercn @joeloff @BrennanConroy @ericstj @wtgodbe