Use WIX_NATIVE_MACHINE to detect native architecture of target machine #37318
Conversation
ghost
added
the
area-infrastructure
Once you have a build with the change, you should be able to grab an arm64 machine and then install both the x64 and arm64 builds. That should be enough to verify the installer change. |
|
You can also test the x64 installer on an x64 machine and observe correct behavior. I tested the host MSI as part of validating the arcade fix which is the same authoring as this. Prior to this change the existing logic has been validated in RC2 builds on both x64 and arm64 hardware. |
|
Please merge when you feel comfortable with PR results. I reran "quarantined" leg because it timed out, not sure if that's required here. I'd like to merge so I can create backport PR. |
|
/backport to release/6.0 |
|
Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1313474891 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1313475623 |
|
Oops, I missed your request for some reason @ericstj. Good thing GitHub's collaborators list is still woefully messed up. /fyi @TanayParikh |
Requires #37290, build will fail until that fix is made.
This leverages the feature I added to Wix which reads the native architecture from the recent feature:
wixtoolset/wix3@75699d8