[release/5.0] Backport x64 on ARM64 installer changes #37407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#36695) * Retarget DOTNETHOME when installing x64 on ARM64 * Make platform comparison case insenstive * Address feedback * Install x64 registry keys to different path on ARM64 machine Co-authored-by: Eric StJohn <[email protected]>
Co-authored-by: Eric StJohn <[email protected]>
… target machine (dotnet#37335) * Use WIX_NATIVE_MACHINE to detect native architecture of target machine * Reference WIX_NATIVE_MACHINE property Final bit to resolve what I'm tracking in dotnet#37290 Co-authored-by: Eric StJohn <[email protected]>
ericstj
requested review from
dougbu,
joeloff,
NikolaMilosavljevic and
wtgodbe
ghost
added
the
area-infrastructure
|
Hi @ericstj. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
joeloff
approved these changes
Oct 8, 2021
dougbu
approved these changes
Oct 8, 2021
Not yet, thus the |
ericstj
added
Servicing-approved
|
This was approved over email. @dotnet/aspnet-build can you help me merge? |
No problem. Thanks for all your work in this area @ericstj❕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean port of all the x64 on ARM64 changes made in 6.0 for 5.0 servicing
6.0 changes: