Change IIS projects to target netcoreapp3.0 #4371
Conversation
|
I think the test projects may be broken for publish. PublishedSitesFixture.cs publishes for netcoreapp2.2 still in tests. Note: tests are still disabled in master due to a websdk issue causing all out of proc tests to fail. |
|
We need to re-enable tests before taking this. |
|
What will it take to re-enable tests? This is blocking lower repos from getting converted. |
|
I think @pakrym is looking into it now. |
Tratcher
force-pushed
the
tratcher/3/IIS
branch
3 times, most recently
from
715c296 to
fc373c1
Compare
|
Just got new hosting dependencies, will update shortly. |
jkotalik
force-pushed
the
tratcher/3/IIS
branch
from
02f7d0e to
fa29343
Compare
jkotalik
force-pushed
the
tratcher/3/IIS
branch
from
d21e39c to
19bf619
Compare
|
We're adding required PR checks to ensure the repo compiles before you merge. Can you update this PR by rebasing on master? Alternative: if you plan to 'squash merge' this PR, you can also use a merge to update this PR. This can be easier to manage if you have lots of changes in this PR. |
|
By the way, you can ignore the error that says "AspNetCore-pr-validation — Unable to find '.azure/pipelines/fast-pr-validation.yml'". This is the result of changing PR checks after a PR was created. It shouldn't appear in PRs created from now on. |
src/IISIntegration/test/Common.FunctionalTests/CompressionTests.cs
Outdated
Show resolved
Hide resolved
|
Tests should be passing now. |
|
Still quite a few test failures where it looks like the server is failing to start. |
|
Looking into it. If I can't figure it out, will disable the first test that is causing the test hang (client disconnect stress). |
|
#4512 for flaky test. |
| @@ -66,7 +66,7 @@ public async Task RequestAbortedTokenFires() | |||
| await _fixture.Client.RetryRequestAsync("/WaitingRequestCount", async message => await message.Content.ReadAsStringAsync() == "0"); | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| [ConditionalFact(Skip = "https://github.com/aspnet/AspNetCore/issues/4512")] | |||
* Change IIS projects to target netcoreapp3.0 dotnet/aspnetcore#3754 Commit migrated from dotnet/aspnetcore@7fdd930f507b
#3754
Also fixed an error in HttpResponseStream.cs. The NETCOREAPP2_1 targets weren't getting compiled since the assembly only targeted netstandard2.0.