Skip to content

Change middleware projects to target netcoreapp3.0 #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Dec 6, 2018

#3754 Blocked on IIS #4371.

@Tratcher Tratcher added this to the 3.0.0-preview2 milestone Dec 6, 2018
@Tratcher Tratcher self-assigned this Dec 6, 2018
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tests pass

@natemcmaster
Copy link
Contributor

We're adding required PR checks to ensure the repo compiles before you merge. Can you update this PR by rebasing on master?

git fetch origin master:master
git rebase master

Alternative: if you plan to 'squash merge' this PR, you can also use a merge to update this PR. This can be easier to manage if you have lots of changes in this PR.

git fetch origin master:master
git merge master

@Tratcher Tratcher force-pushed the tratcher/3/middleware branch from e94d9d8 to c95aede Compare December 11, 2018 19:05
@Tratcher
Copy link
Member Author

Rebased. I've opted to skip ForwardedHeaders for now as that's blocked on IIS. Getting ResponseCompression up to 3.0 unblocks some feature work I'd like to start.

@Tratcher
Copy link
Member Author

Nope, IIS tests also depend on ResponseCompression ....

@Tratcher Tratcher force-pushed the tratcher/3/middleware branch from c95aede to 0ac15cc Compare December 11, 2018 21:49
@Tratcher Tratcher merged commit 97cdbfb into master Dec 11, 2018
@Tratcher Tratcher deleted the tratcher/3/middleware branch December 11, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants