Skip to content

Update SDK #44601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2022
Merged

Update SDK #44601

merged 8 commits into from
Oct 24, 2022

Conversation

MackinnonBuck
Copy link
Member

No description provided.

@MackinnonBuck MackinnonBuck added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 17, 2022
@MackinnonBuck MackinnonBuck requested review from a team, dougbu and wtgodbe as code owners October 17, 2022 17:25
@ghost
Copy link

ghost commented Oct 17, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@MackinnonBuck
Copy link
Member Author

Hm, looks like we're getting consistent restore failures on Linux x64:

/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: The "RestoreTask" task failed unexpectedly. [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) The "RestoreTask" task failed unexpectedly. [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: System.Threading.AbandonedMutexException: The wait completed due to an abandoned mutex. [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) System.Threading.AbandonedMutexException: The wait completed due to an abandoned mutex. [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: at System.Threading.WaitHandle.WaitOneNoCheck(Int32 millisecondsTimeout) [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at System.Threading.WaitHandle.WaitOneNoCheck(Int32 millisecondsTimeout) [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: at NuGet.Common.Migrations.MigrationRunner.Run() [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at NuGet.Common.Migrations.MigrationRunner.Run() [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: at NuGet.Build.Tasks.RestoreTask.Execute() [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at NuGet.Build.Tasks.RestoreTask.Execute() [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/tmp/ny2zgffl.epz/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/tmp/ny2zgffl.epz/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.22513.2/tools/Tools.proj]
##[error].dotnet/sdk/8.0.100-alpha.1.22514.14/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/tmp/ny2zgffl.epz/restore.csproj]

We should try updating to the next nightly tomorrow and see if the issue persists.

@TanayParikh
Copy link
Contributor

TanayParikh commented Oct 18, 2022 •
edited
Loading

We should try updating to the next nightly tomorrow and see if the issue persists.

8.0.100-alpha.1.22514.14 is still latest, awaiting next bump.

Edit: 3:45 PM PT, still no bump available.

Edit: Oct 19, 11:25 AM PT, still no bump.

@TanayParikh
Copy link
Contributor

Still no bump. @mmitche is something potentially blocked in the pipeline, or are bumps just less frequent at this stage in the release?

brunolins16
brunolins16 reviewed Oct 24, 2022
View reviewed changes
src/Servers/Kestrel/Core/src/KestrelServerOptions.cs
@@ -252,9 +252,6 @@ internal void Serialize(Utf8JsonWriter writer)
writer.WritePropertyName(nameof(AllowResponseHeaderCompression));
writer.WriteBooleanValue(AllowResponseHeaderCompression);

writer.WritePropertyName(nameof(EnableAltSvc));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfowl @Tratcher EnableAltSvc is marked as obsolete and causing build errors. I am removing from here. since the message explicitly say that it no longer has any impact on runtime behavior, that will cause the property not to be serialized when emitting the kestrel (Microsoft-AspNetCore-Server-Kestrel) configuration event (ID: 11).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brunolins16
Copy link
Member

@wtgodbe @dougbu can you please review.

@brunolins16 brunolins16 merged commit 1e8fe7e into main Oct 24, 2022
@brunolins16 brunolins16 deleted the mbuck/update-sdk-2022-10-17 branch October 24, 2022 23:42
@ghost ghost added this to the 8.0-preview1 milestone Oct 24, 2022
brunolins16 added a commit that referenced this pull request Oct 25, 2022
@brunolins16
Revert "Update SDK (#44601)"
56a7d75 
This reverts commit 1e8fe7e.
@brunolins16 brunolins16 mentioned this pull request Oct 25, 2022
Merged
brunolins16 added a commit that referenced this pull request Oct 25, 2022
@brunolins16
Revert "Update SDK (#44601)" (#44730)
be9e309 
This reverts commit 1e8fe7e.
brunolins16 added a commit to brunolins16/aspnetcore that referenced this pull request Oct 25, 2022
@MackinnonBuck @sebastienros @brunolins16
Update SDK (dotnet#44601)
edb20a3 
* Update SDK

* Update global.json

* Trying previous version

* Update global.json

* Updating 8.0.100-alpha.1.22524

* Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9

* Fix CA1507

* Removing EnableAltSvc

Co-authored-by: Sébastien Ros <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
brunolins16 added a commit to brunolins16/aspnetcore that referenced this pull request Oct 25, 2022
@MackinnonBuck @sebastienros @brunolins16
Update SDK (dotnet#44601)
28e718e 
* Update SDK

* Update global.json

* Trying previous version

* Update global.json

* Updating 8.0.100-alpha.1.22524

* Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9

* Fix CA1507

* Removing EnableAltSvc

Co-authored-by: Sébastien Ros <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
brunolins16 added a commit to brunolins16/aspnetcore that referenced this pull request Oct 25, 2022
@MackinnonBuck @sebastienros @brunolins16
Update SDK (dotnet#44601)
d0d8803 
* Update SDK

* Update global.json

* Trying previous version

* Update global.json

* Updating 8.0.100-alpha.1.22524

* Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9

* Fix CA1507

* Removing EnableAltSvc

Co-authored-by: Sébastien Ros <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
@brunolins16 brunolins16 mentioned this pull request Oct 25, 2022
Merged
brunolins16 added a commit that referenced this pull request Oct 26, 2022
@brunolins16 @MackinnonBuck @sebastienros
Updating SDK version (#44734)
68fcc9c 
* Update SDK (#44601)

* Update SDK

* Update global.json

* Trying previous version

* Update global.json

* Updating 8.0.100-alpha.1.22524

* Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9

* Fix CA1507

* Removing EnableAltSvc

Co-authored-by: Sébastien Ros <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>

* Adding nuget --version workaround

Co-authored-by: Mackinnon Buck <[email protected]>
Co-authored-by: Sébastien Ros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunolins16 brunolins16 brunolins16 left review comments

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
6 participants
@MackinnonBuck @TanayParikh @brunolins16 @Tratcher @dougbu @sebastienros