Skip to content

Update SDK #44601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 24, 2022
Merged

Update SDK #44601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce62df9
Update SDK
MackinnonBuck Oct 17, 2022
5b0b7d0
Update global.json
sebastienros Oct 23, 2022
1b53223
Trying previous version
sebastienros Oct 24, 2022
eeb8f4e
Update global.json
sebastienros Oct 24, 2022
02622f0
Updating 8.0.100-alpha.1.22524
brunolins16 Oct 24, 2022
d17cf79
Updating MicrosoftNetCompilersToolsetVersion to 4.5.0-1.22517.9
brunolins16 Oct 24, 2022
9d693f8
Fix CA1507
brunolins16 Oct 24, 2022
9a27b9f
Removing EnableAltSvc
brunolins16 Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
<PropertyGroup Label="Manual">
<!-- Bumping the Roslyn version used in order to ingest the new runtime source generators -->
<UsingToolMicrosoftNetCompilers>true</UsingToolMicrosoftNetCompilers>
<MicrosoftNetCompilersToolsetVersion>4.4.0-3.22452.8</MicrosoftNetCompilersToolsetVersion>
<MicrosoftNetCompilersToolsetVersion>4.5.0-1.22517.9</MicrosoftNetCompilersToolsetVersion>
<!-- DiagnosticAdapter package pinned temporarily until migrated/deprecated -->
<MicrosoftExtensionsDiagnosticAdapterVersion>5.0.0-preview.4.20180.4</MicrosoftExtensionsDiagnosticAdapterVersion>
<!-- Build tool dependencies -->
Expand Down
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "8.0.100-alpha.1.22480.9"
"version": "8.0.100-alpha.1.22524.1"
},
"tools": {
"dotnet": "8.0.100-alpha.1.22480.9",
"dotnet": "8.0.100-alpha.1.22524.1",
"runtimes": {
"dotnet/x86": [
"$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"
Expand Down
2 changes: 1 addition & 1 deletion src/Features/JsonPatch/src/Operations/Operation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.JsonPatch.Operations;

public class Operation : OperationBase
{
[JsonProperty("value")]
[JsonProperty(nameof(value))]
public object value { get; set; }

public Operation()
Expand Down
6 changes: 3 additions & 3 deletions src/Features/JsonPatch/src/Operations/OperationBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ public OperationType OperationType
}
}

[JsonProperty("path")]
[JsonProperty(nameof(path))]
public string path { get; set; }

[JsonProperty("op")]
[JsonProperty(nameof(op))]
public string op
{
get
Expand All @@ -42,7 +42,7 @@ public string op
}
}

[JsonProperty("from")]
[JsonProperty(nameof(from))]
public string from { get; set; }

public OperationBase()
Expand Down
3 changes: 0 additions & 3 deletions src/Servers/Kestrel/Core/src/KestrelServerOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ internal void Serialize(Utf8JsonWriter writer)
writer.WritePropertyName(nameof(AllowResponseHeaderCompression));
writer.WriteBooleanValue(AllowResponseHeaderCompression);

writer.WritePropertyName(nameof(EnableAltSvc));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfowl @Tratcher EnableAltSvc is marked as obsolete and causing build errors. I am removing from here. since the message explicitly say that it no longer has any impact on runtime behavior, that will cause the property not to be serialized when emitting the kestrel (Microsoft-AspNetCore-Server-Kestrel) configuration event (ID: 11).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

writer.WriteBooleanValue(EnableAltSvc);

writer.WritePropertyName(nameof(IsDevCertLoaded));
writer.WriteBooleanValue(IsDevCertLoaded);

Expand Down