Merge branch 'release/2.2' into 'master' #4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
requested review from
natemcmaster,
jkotalik,
mikaelm12 and
JunTaoLuo
natemcmaster
approved these changes
Dec 13, 2018
mikaelm12
approved these changes
Dec 13, 2018
JunTaoLuo
approved these changes
Dec 13, 2018
|
@mikaelm12, looks like something is failing in CORS functional test. Could you take a look? I think you can just merge this once that is fixed |
|
Taking a look |
mikaelm12
reviewed
Dec 13, 2018
src/Middleware/CORS/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
Outdated
Show resolved
Hide resolved
src/Middleware/CORS/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
Outdated
Show resolved
Hide resolved
…nalTest.cs Co-Authored-By: ajaybhargavb <[email protected]>
…nalTest.cs Co-Authored-By: ajaybhargavb <[email protected]>
mikaelm12
reviewed
Dec 14, 2018
src/Middleware/CORS/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
Outdated
Show resolved
Hide resolved
…nalTest.cs Co-Authored-By: ajaybhargavb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.