Skip to content

Add custom message to NavigationException #54862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

carlos-regis
Copy link

Fixes #51787

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes:

  • Overrides the Message property for the NavigationException

@carlos-regis carlos-regis requested a review from a team as a code owner April 1, 2024 06:44
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 1, 2024
@carlos-regis
Copy link
Author

@danmoseley Please let me know if you want to customize the message with more specific details.

@carlos-regis
Copy link
Author

@javiercn @mkArtakMSFT fyi this PR closes #51787

@danmoseley
Copy link
Member

Thanks @carlos-regis. I'll let Blazor owners review. Can you remove the extra whitespace you added?
Is a simple test feasible? It would simply check the URI was somewhere in the message.

@carlos-regis
Copy link
Author

Thanks @carlos-regis. I'll let Blazor owners review. Can you remove the extra whitespace you added? Is a simple test feasible? It would simply check the URI was somewhere in the message.

@MackinnonBuck could you please provide me with some guidance on this test? regarding where in the codebase should I create it and what else you think would be nice to know as this is my first contrib for the blazor area.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 18, 2024
@MackinnonBuck
Copy link
Member

Since there hasn't been activity in a while, we're going to close this out in favor of #56644

@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationException doesn't have a useful message.
5 participants