Skip to content

Navigation Exception: Introduce Clear Message #56644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

spdebeer
Copy link

@spdebeer spdebeer commented Jul 5, 2024

Navigation Exception: Introduce Clear Message

Description:
This pull request is for adding a useful message to the NavigationException when thrown.

Changes:

  • Pass a message to the base of the NavigationException class

Fixes #51787

@spdebeer spdebeer requested a review from a team as a code owner July 5, 2024 10:12
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jul 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 5, 2024
@spdebeer
Copy link
Author

spdebeer commented Jul 5, 2024

@spdebeer please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Retro Rabbit"

@javiercn javiercn added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Jul 5, 2024
@spdebeer spdebeer marked this pull request as draft July 8, 2024 07:39
@spdebeer spdebeer changed the title Navigation Exception: Introduce Clear Message & Helper Class Navigation Exception: Introduce Clear Message Jul 11, 2024
@spdebeer spdebeer marked this pull request as ready for review July 11, 2024 07:25
@spdebeer spdebeer requested a review from javiercn July 18, 2024 14:18
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the stale Indicates a stale issue. These issues will be closed automatically soon. label Aug 5, 2024
@dotnet-policy-service dotnet-policy-service bot removed stale Indicates a stale issue. These issues will be closed automatically soon. pr: pending author input For automation. Specifically separate from Needs: Author Feedback labels Aug 6, 2024
@spdebeer
Copy link
Author

spdebeer commented Aug 6, 2024

hi @javiercn, would you mind having a look again

This reverts commit 03dfcce.
@javiercn
Copy link
Member

Our plan of record has changed here, and we plan to address it via, which will get rid of the exception altogether #59451

@javiercn javiercn closed this Jan 24, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationException doesn't have a useful message.
2 participants