Pack symbols in SharedFx for libraries we redist from runtime #62429
Conversation
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull Request Overview
This PR enables explicit symbol packaging for libraries redistributed from the runtime by adding a PackageReference and new MSBuild ItemGroup entries to include relevant PDB files.
- Adds a PackageReference for "Microsoft.Internal.Runtime.AspNetCore.Transport"
- Introduces ItemGroups to include and conditionally package symbol files in both the runtime and composite projects
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj | Inserts PackageReference and symbol inclusion logic for runtime symbols |
| src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj | Mirrors the runtime project changes to include symbol files in the composite project |
| Name="%(Filename)" /> | ||
|
|
||
| <_SymbolFilesToPackage Include="@(_TransportPdbsWithName)" | ||
| Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" /> |
There was a problem hiding this comment.
Consider refactoring this duplicated symbol packaging block into a shared targets or props file to improve maintainability across projects.
Copilot uses AI. Check for mistakes.
| Name="%(Filename)" /> | ||
|
|
||
| <_SymbolFilesToPackage Include="@(_TransportPdbsWithName)" | ||
| Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" /> |
There was a problem hiding this comment.
Consider refactoring this duplicated symbol packaging block into a shared targets or props file to improve maintainability across projects.
Copilot uses AI. Check for mistakes.
src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
Outdated
Show resolved
Hide resolved
src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM to unblock the missing symbols but we should (ideally immediately) follow-up with only consuming the transport package and not the individual packages anymore.
Also let NuGet handle referencing and bringing the assets in. I didn't have to change a single LOC in windowsdesktop.
|
/backport to release/10.0-preview6 |
|
Started backporting to release/10.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/15835680419 |
Fixes #62165. Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2735990&view=results