Skip to content

Add System.Security.Cryptography.Pkcs to aspnetcore transport package #116927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 23, 2025

This library is in aspnetcore's shared framework (but not its ref pack). Adding it to the aspnetcore transport package will allow aspnetcore to redist its .pdb.

@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 19:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the System.Security.Cryptography.Pkcs assembly to the ASP.NET Core transport package so that its PDB can be redistributed.

  • Includes the new System.Security.Cryptography.Pkcs reference in the shared framework props.
  • Ensures the assembly appears alongside other cryptography libraries.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 23, 2025
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 23, 2025

Related: dotnet/aspnetcore#62429

@wtgodbe wtgodbe enabled auto-merge (squash) June 23, 2025 19:23
@teo-tsirpanis teo-tsirpanis added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 23, 2025
@wtgodbe wtgodbe disabled auto-merge June 23, 2025 20:54
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 23, 2025

Need to fix this up so both the net10.0 and net10.0-windows assemblies get included for pkcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants