Use Pipelines in PlaintextApp sample #7227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
reviewed
Feb 4, 2019
benaadams
force-pushed
the
Use-pipelines
branch
from
02fac9f to
a082669
Compare
|
@benaadams agreed, we should probably avoid merging this PR until #7110 is in. |
halter73
reviewed
Feb 4, 2019
benaadams
force-pushed
the
Use-pipelines
branch
from
9da7e32 to
7c36421
Compare
|
Called it |
davidfowl
reviewed
Feb 5, 2019
davidfowl
reviewed
Feb 5, 2019
Tratcher
reviewed
Feb 5, 2019
| internal static class ValueTaskExtensions | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static Task GetAsTask(this in ValueTask<FlushResult> valueTask) |
There was a problem hiding this comment.
Seems like this could be submitted as an improvement to AsTask?
There was a problem hiding this comment.
Its converting a result type ValueTask<T> task-like to a non-result type Task
AsTask() would covert it to Task<T> would need a different name to work with overloading?
There was a problem hiding this comment.
Right, this would need to go into pipelines itself.
|
/AzurePipelines run AspNetCore-ci |
davidfowl
approved these changes
Feb 5, 2019
halter73
approved these changes
Feb 5, 2019
|
Any reason this wasn't merged... 2 months ago 😱? Looks approved and builds are green... |
|
Forgot, or the perf tests weren’t running |
|
Are we good to merge or is there something we're waiting on? |
davidfowl
approved these changes
May 25, 2019
Merged
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess it would be a regression until #7110 is merged?
/cc @davidfowl @jkotalik
@halter73 @pakrym @Tratcher