Skip to content

Use Pipelines in PlaintextApp sample #7227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2019
Merged

Use Pipelines in PlaintextApp sample #7227

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b1dcfb
Use Pipelines in PlaintextApp sample
benaadams Feb 4, 2019
a082669
Feedback
benaadams Feb 4, 2019
7c36421
Use GetAsTask
benaadams Feb 5, 2019
ae87216
Go lambda
benaadams Feb 5, 2019
7311885
Don't use open generic
benaadams Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/Servers/Kestrel/samples/PlaintextApp/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using System.IO;
using System.IO.Pipelines;
using System.Net;
using System.Runtime.CompilerServices;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
Expand All @@ -18,13 +20,14 @@ public void Configure(IApplicationBuilder app)
{
app.Run((httpContext) =>
{
var payload = _helloWorldBytes;
var response = httpContext.Response;

response.StatusCode = 200;
response.ContentType = "text/plain";
response.ContentLength = payload.Length;

var helloWorld = _helloWorldBytes;
response.ContentLength = helloWorld.Length;
return response.Body.WriteAsync(helloWorld, 0, helloWorld.Length);
return response.BodyPipe.WriteAsync(payload).GetAsTask();
});
}

Expand All @@ -42,4 +45,22 @@ public static Task Main(string[] args)
return host.RunAsync();
}
}

internal static class ValueTaskExtensions
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Task GetAsTask(this in ValueTask<FlushResult> valueTask)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could be submitted as an improvement to AsTask?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its converting a result type ValueTask<T> task-like to a non-result type Task

AsTask() would covert it to Task<T> would need a different name to work with overloading?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this would need to go into pipelines itself.

{
if (valueTask.IsCompletedSuccessfully)
{
// Signal consumption to the IValueTaskSource
valueTask.GetAwaiter().GetResult();
return Task.CompletedTask;
}
else
{
return valueTask.AsTask();
}
}
}
}