-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Quarantine a bunch of flaky tests #9751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edWithNotNullParameters
…oreAndAfterHttpsAdapter
Update: The quarantines are done, but I'm sure I have some build issues to fix. I did this in VS code because it was across many projects and getting the CI to build this seemed like a more productive use of time :). Will undraft and ping when the build is clean. |
jkotalik
approved these changes
Apr 25, 2019
This was referenced Apr 16, 2021
This was referenced Apr 26, 2021
This was referenced Sep 16, 2021
This was referenced Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-hosting
Includes Hosting
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
area-signalr
Includes: SignalR clients and servers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Flaky
attributes to get some flaky tests out of the way of the build.Also converted some skipped things that were just skipped because they wer failing and we didn't know for sure what was going on to properly quarantined. We'll see what RaaS finds there.
Finally, updated some broken
Flaky
links (or links to issues that were transferred to a different repo)Currently draft as I'm going through the list and trying to a full batch of things to improve build reliablity.