Quarantine a bunch of flaky tests

src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs

@@ -5,6 +5,7 @@
 using System.Diagnostics.Tracing;
 using System.Reflection;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.AspNetCore.Testing.xunit;
 using Xunit;
 
@@ -108,7 +109,7 @@ public static TheoryData<DefaultHttpContext, string[]> RequestStartData
 
         [Theory]
         [MemberData(nameof(RequestStartData))]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2040", "All")]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2230", FlakyOn.All)]
         public void RequestStart(DefaultHttpContext httpContext, string[] expected)
         {
             // Arrange

src/Hosting/Hosting/test/WebHostTests.cs

@@ -14,6 +14,7 @@
 using Microsoft.AspNetCore.Hosting.Server.Features;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Features;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.AspNetCore.Testing.xunit;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
@@ -238,7 +239,7 @@ public async Task WebHostStopAsyncUsesDefaultTimeoutIfGivenTokenDoesNotFire()
         }
 
         [ConditionalFact]
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7291
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2244", FlakyOn.Helix.All)]
         public async Task WebHostStopAsyncUsesDefaultTimeoutIfNoTokenProvided()
         {
             var data = new Dictionary<string, string>

src/Servers/HttpSys/test/FunctionalTests/HttpsTests.cs

@@ -12,15 +12,18 @@
 using Microsoft.AspNetCore.Connections.Features;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Features;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.AspNetCore.Testing.xunit;
 using Xunit;
 
 namespace Microsoft.AspNetCore.Server.HttpSys
 {
-    [SkipOnHelix] // https://github.com/aspnet/AspNetCore-Internal/issues/1816
+    // Flaky doesn't support classes :(
+    // https://github.com/aspnet/Extensions/issues/1568
     public class HttpsTests
     {
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         public async Task Https_200OK_Success()
         {
             using (Utilities.CreateDynamicHttpsServer(out var address, httpContext =>
@@ -34,6 +37,7 @@ public async Task Https_200OK_Success()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         public async Task Https_SendHelloWorld_Success()
         {
             using (Utilities.CreateDynamicHttpsServer(out var address, httpContext =>
@@ -49,6 +53,7 @@ public async Task Https_SendHelloWorld_Success()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         public async Task Https_EchoHelloWorld_Success()
         {
             using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
@@ -66,6 +71,7 @@ public async Task Https_EchoHelloWorld_Success()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         public async Task Https_ClientCertNotSent_ClientCertNotPresent()
         {
             using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
@@ -102,6 +108,7 @@ public async Task Https_ClientCertRequested_ClientCertPresent()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         [OSDontSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)]
         public async Task Https_SkipsITlsHandshakeFeatureOnWin7()
         {
@@ -124,6 +131,7 @@ public async Task Https_SkipsITlsHandshakeFeatureOnWin7()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.Helix.All)]
         [OSSkipCondition(OperatingSystems.Windows, WindowsVersions.Win7, WindowsVersions.Win2008R2)]
         public async Task Https_SetsITlsHandshakeFeature()
         {

src/Servers/HttpSys/test/FunctionalTests/Listener/RequestBodyTests.cs

@@ -143,6 +143,7 @@ public async Task RequestBody_ReadAsyncPartialBodyAndCancel_Canceled()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2206", FlakyOn.All)]
         public async Task RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled()
         {
             StaggardContent content = new StaggardContent();

src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs

@@ -46,6 +46,7 @@ public async Task Caching_NoCacheControl_NotCached()
         }
 
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2135", FlakyOn.All)]
         public async Task Caching_JustPublic_NotCached()
         {
             var requestCount = 1;
@@ -86,7 +87,7 @@ public async Task Caching_WithoutContentType_NotCached()
         }
 
         [ConditionalFact]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2207", FlakyOn.All)]
         public async Task Caching_WithoutContentType_Cached_OnWin7AndWin2008R2()
         {
             if (Utilities.IsWin8orLater)
@@ -237,7 +238,7 @@ public async Task Caching_DisallowedResponseHeaders_NotCached(string headerName)
         [ConditionalTheory]
         [InlineData("0")]
         [InlineData("-1")]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2208", FlakyOn.All)]
         public async Task Caching_InvalidExpires_NotCached(string expiresValue)
         {
             var requestCount = 1;
@@ -378,7 +379,7 @@ public async Task Caching_SendFileWithFullContentLength_Cached()
         }
 
         [ConditionalFact]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2209", FlakyOn.All)]
         public async Task Caching_VariousStatusCodes_Cached()
         {
             var requestCount = 1;

src/Servers/IIS/IIS/test/Common.FunctionalTests/AppOfflineTests.cs

@@ -78,7 +78,7 @@ public async Task AppOfflineDroppedWhileSiteFailedToStartInShim_AppOfflineServed
             DeletePublishOutput(deploymentResult);
         }
 
-        [ConditionalFact(Skip = "https://github.com/aspnet/IISIntegration/issues/933")]
+        [ConditionalFact(Skip = "https://github.com/aspnet/AspNetCore/issues/3835")]
         public async Task AppOfflineDroppedWhileSiteFailedToStartInRequestHandler_SiteStops_InProcess()
         {
             var deploymentResult = await DeployApp(HostingModel.InProcess);

src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs

@@ -107,13 +107,13 @@ public async Task StartsWithDotnetOnThePath(string path)
             Assert.Equal(1, TestSink.Writes.Count(w => w.Message.Contains("Invoking where.exe to find dotnet.exe")));
         }
 
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972
         [ConditionalTheory]
         [InlineData(RuntimeArchitecture.x64)]
         [InlineData(RuntimeArchitecture.x86)]
         [SkipIfNotAdmin]
         [RequiresNewShim]
         [RequiresIIS(IISCapability.PoolEnvironmentVariables)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2221", FlakyOn.Helix.All)]
         public async Task StartsWithDotnetInstallLocation(RuntimeArchitecture runtimeArchitecture)
         {
             var deploymentParameters = Fixture.GetBaseDeploymentParameters();
@@ -651,7 +651,7 @@ public async Task ExceptionIsLoggedToEventLogDoesNotWriteToResponse()
 
         private static void VerifyDotnetRuntimeEventLog(IISDeploymentResult deploymentResult)
         {
-            var entries = GetEventLogsFromDotnetRuntime(deploymentResult); 
+            var entries = GetEventLogsFromDotnetRuntime(deploymentResult);
 
             var expectedRegex = new Regex("Exception Info: System\\.InvalidOperationException:", RegexOptions.Singleline);
             var matchedEntries = entries.Where(entry => expectedRegex.IsMatch(entry.Message)).ToArray();

src/Servers/IIS/IIS/test/Common.FunctionalTests/LogFileTests.cs

@@ -171,8 +171,8 @@ public async Task DebugLogsAreWrittenToEventLog(TestVariant variant)
         }
 
         [ConditionalTheory]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2200", FlakyOn.All)]
         [MemberData(nameof(TestVariants))]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2200", FlakyOn.All)]
         public async Task CheckUTF8File(TestVariant variant)
         {
             var path = "CheckConsoleFunctions";

src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs

@@ -15,7 +15,7 @@ public class MofFileTests
         [ConditionalFact]
         [OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
         [RequiresIIS(IISCapability.TracingModule)]
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2222", FlakyOn.Helix.All)]
         public void CheckMofFile()
         {
             var path = Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"), "aspnetcoremodulev2", "aspnetcore", "ancm.mof");

src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs

@@ -20,6 +20,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
     public class ClientDisconnectTests : StrictTestServerTests
     {
         [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2358", FlakyOn.All)]
         public async Task WritesSucceedAfterClientDisconnect()
         {
             var requestStartedCompletionSource = CreateTaskCompletionSource();
@@ -178,7 +179,7 @@ public async Task WriterThrowsCancelledException()
         }
 
         [ConditionalFact]
-        [Repeat(100)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1798", FlakyOn.All)]
         public async Task ReaderThrowsCancelledException()
         {
             var requestStartedCompletionSource = CreateTaskCompletionSource();

src/Servers/Kestrel/Kestrel/test/GeneratedCodeTests.cs

@@ -5,15 +5,16 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.AspNetCore.Testing.xunit;
 using Xunit;
 
 namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
 {
     public class GeneratedCodeTests
     {
-        [ConditionalFact] 
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6720
+        [ConditionalFact]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2223", FlakyOn.Helix.All)]
         public void GeneratedCodeIsUpToDate()
         {
             var repositoryRoot = typeof(GeneratedCodeTests).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>().First(f => string.Equals(f.Key, "RepositoryRoot", StringComparison.OrdinalIgnoreCase)).Value;

src/Servers/Kestrel/test/FunctionalTests/RequestTests.cs

@@ -137,7 +137,7 @@ public Task RemoteIPv4Address()
         [ConditionalFact]
         [IPv6SupportedCondition]
 #if LIBUV
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8109
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1977", FlakyOn.Helix.All)] // https://github.com/aspnet/AspNetCore/issues/8109
 #endif
         public Task RemoteIPv6Address()
         {
@@ -796,7 +796,7 @@ await connection.Send(
 
         [Theory]
 #if LIBUV
-        [SkipOnHelix]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1971", FlakyOn.Helix.All)]
 #endif
         [MemberData(nameof(ConnectionAdapterData))]
         public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions)

src/Servers/Kestrel/test/FunctionalTests/ResponseTests.cs

@@ -342,7 +342,7 @@ await connection.Send(
         }
 
         [Theory]
-        [Flaky("https://github.com/aspnet/AspNetCore/issues/7342", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1972", FlakyOn.All)]
         [MemberData(nameof(ConnectionAdapterData))]
         public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)
         {

src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionAdapterTests.cs

@@ -447,7 +447,7 @@ public async Task DoesNotSupportTls10()
         }
 
         [Theory]
-        [Flaky("https://github.com/aspnet/AspNetCore/issues/7265", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1976", FlakyOn.All)]
         [InlineData(ClientCertificateMode.AllowCertificate)]
         [InlineData(ClientCertificateMode.RequireCertificate)]
         public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode)
@@ -485,7 +485,7 @@ public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(Cli
         }
 
         [ConditionalTheory]
-        [SkipOnHelix]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1950", FlakyOn.Helix.All)]
         [InlineData(ClientCertificateMode.AllowCertificate)]
         [InlineData(ClientCertificateMode.RequireCertificate)]
         public async Task ValidationFailureRejectsConnection(ClientCertificateMode mode)

src/Servers/Kestrel/test/InMemory.FunctionalTests/LoggingConnectionAdapterTests.cs

@@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
     public class LoggingConnectionAdapterTests : LoggedTest
     {
         [Fact]
-        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1753", FlakyOn.Helix.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2276", FlakyOn.Helix.All)]
         public async Task LoggingConnectionAdapterCanBeAddedBeforeAndAfterHttpsAdapter()
         {
             await using (var server = new TestServer(context =>

src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs

@@ -25,7 +25,7 @@ public class H2SpecTests : LoggedTest
     {
         [ConditionalTheory]
         [MemberData(nameof(H2SpecTestCases))]
-        [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7299
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2225", FlakyOn.Helix.All)]
         public async Task RunIndividualTestCase(H2SpecTestCase testCase)
         {
             var hostBuilder = new WebHostBuilder()

src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs

@@ -2077,7 +2077,7 @@ public async Task LongPollingCanPollIfWritePipeHasBackpressure()
         }
 
         [Fact]
-        [Flaky("https://github.com/aspnet/AspNetCore/issues/8138", FlakyOn.All)]
+        [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1975", FlakyOn.All)]
         public async Task ErrorDuringPollWillCloseConnection()
         {
             bool ExpectedErrors(WriteContext writeContext)