Add IConnectionCompleteFeature.OnCompleted #9754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
commented
Apr 25, 2019
...Servers/Kestrel/Transport.Abstractions/src/Internal/TransportConnection.FeatureCollection.cs
Outdated
Show resolved
Hide resolved
|
cc @BrennanConroy @mikaelm12 @halter73 We may want to implement this feature in SignalR. It could be useful. |
|
How is this different from IConnectionLifetime |
|
IConnectionLifetime ConnectionClosed will fire immediately, possibly in the middle of requests. Trying to use it for cleanup would cause lots of race conditions and ObjectDisposedExceptions up stack. OnCompleted acts as a finally block for the connection, allowing you to clean up resources once you're sure everybody is done using them. |
halter73
reviewed
Apr 29, 2019
halter73
reviewed
Apr 29, 2019
...Servers/Kestrel/Transport.Abstractions/src/Internal/TransportConnection.FeatureCollection.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 29, 2019
...Servers/Kestrel/Transport.Abstractions/src/Internal/TransportConnection.FeatureCollection.cs
Outdated
Show resolved
Hide resolved
Tratcher
force-pushed
the
tratcher/connection
branch
from
b513da6 to
dfb5d6c
Compare
halter73
approved these changes
Apr 29, 2019
4 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9213 This is a copy of the HttpResponse.OnCompleted feature down to the connection level. It's intended for resource cleanup at the end of the connection lifecycle and will be used by KerberosAuth to eagerly Dispose state (#8897).