Skip to content

Add new Negotiate Auth handler #9831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
May 22, 2019
Merged

Add new Negotiate Auth handler #9831

merged 40 commits into from
May 22, 2019

Conversation

Tratcher
Copy link
Member

#4662 This is a new package for Negotiate (NTLM/Kerberos) auth. It will not be part of the shared framework.

Starting as a draft while we work out some of the error conditions and add the new connection cleanup feature: #9754.

@blowdart

@Tratcher Tratcher added this to the 3.0.0-preview6 milestone Apr 29, 2019
@Tratcher Tratcher requested review from HaoK and a team April 29, 2019 18:37
@Tratcher Tratcher self-assigned this Apr 29, 2019
@blowdart
Copy link
Contributor

I am here for "Misadventures in Dockerland"

dougbu
dougbu reviewed Apr 29, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects and infrastructure changes look good. No comment on the C# files.

@Tratcher
Copy link
Member Author

@blowdart I tried to run a hello world sample in docker before I even started auth. It failed miserably and I wasted a day trying to figure it out before deleting it.

@Tratcher Tratcher mentioned this pull request Apr 29, 2019
Closed
@Eilon Eilon added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Apr 29, 2019
@Tratcher Tratcher force-pushed the tratcher/kerbproof branch 2 times, most recently from c15a3cd to 879b14f Compare May 4, 2019 15:29
@Tratcher Tratcher force-pushed the tratcher/kerbproof branch from 497bdfa to a8bbac2 Compare May 14, 2019 21:07
@Tratcher Tratcher marked this pull request as ready for review May 14, 2019 22:30
@Tratcher
Copy link
Member Author

@aspnet/build how do I tell it that the Negotiate.Client and Server projects are test assets and should not be included in eng/ProjectReferences.props?

@Tratcher Tratcher force-pushed the tratcher/kerbproof branch from adcc235 to 40091e9 Compare May 17, 2019 16:32
@Tratcher
Copy link
Member Author

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=192518

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2534

@Tratcher Tratcher merged commit f5879cc into master May 22, 2019
@Tratcher Tratcher deleted the tratcher/kerbproof branch May 22, 2019 13:14
DylanDmitri pushed a commit that referenced this pull request May 27, 2019
@Tratcher @DylanDmitri
Add new Negotiate Auth handler (#9831)
d072508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nil4 nil4 nil4 left review comments

@dougbu dougbu dougbu left review comments

@mconnew mconnew mconnew left review comments

@HaoK HaoK HaoK approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees

@Tratcher Tratcher

Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
3.0.0-preview6
Development

Successfully merging this pull request may close these issues.
10 participants
@Tratcher @blowdart @natemcmaster @aspnet-hello @analogrelay @nil4 @dougbu @HaoK @mconnew @Eilon