This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Add global NoWarn for: 'NU5104' #9495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MSBuildSdkResolver' now throws a "NU5104" warning/error because the SDK stage0 was changed to "2.1.300" [change was intended].
dagood
approved these changes
Jun 14, 2018
build/BuildDefaults.props
Outdated
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| <!-- Disable asset target fallback warning globally since it does not work transitively on NoWarn of individual packages --> | |||
| <!-- Since we disabled the implict fallback to net461, this will only kick in when we have an explicit fallback and we don't need to be warned about it doing what we asked it to do. --> | |||
| <NoWarn>NU1701</NoWarn> | |||
| <NoWarn>NU1701;NU5104</NoWarn> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "pack" command under 'buildCrossTargeting' for 'Microsoft.DotNet.MSBuildSdkResolver' now throws a "NU5104" warning/error because the SDK stage0 was changed to "2.1.300" [change was intended].
Impacts: Linux-x64, Linux-arm, and Linux-arm64
Related: dotnet/source-build#569
Example error:
From: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/Default/_build/results?buildId=1773593
/opt/code/.dotnet_stage0/arm/sdk/2.1.300/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(198,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "NuGet.Frameworks [4.7.0-rtm.5148, )" or update the version field in the nuspec.
Successful VSO build - Linux-arm: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/Default/_build/results?buildId=1776356
Successful VSO build - Linux-arm:
dropsuffix=true
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/Default/_build/results?buildId=1776659
from the log:
GenerateArchives:
/bin/tar -czf /opt/code/bin/2/linux-arm/packages/dotnet-sdk-2.1.301-linux-arm.tar.gz