Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Add global NoWarn for: 'NU5104' #9495

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Add global NoWarn for: 'NU5104' #9495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4050c63
The "pack" command under 'buildCrossTargeting' for 'Microsoft.DotNet.…
Jun 14, 2018
c0c445b
Updating the 'NoWarn' comments.
Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions build/BuildDefaults.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@
<!-- Only use asset target fallback that we set (not implicit one to net461). -->
<DisableImplicitAssetTargetFallback>true</DisableImplicitAssetTargetFallback>

<!-- Disable asset target fallback warning globally since it does not work transitively on NoWarn of individual packages -->
<!-- NU1701: Disable asset target fallback warning globally since it does not work transitively on NoWarn of individual packages -->
<!-- Since we disabled the implict fallback to net461, this will only kick in when we have an explicit fallback and we don't need to be warned about it doing what we asked it to do. -->
<NoWarn>NU1701</NoWarn>
<!-- NU5104: Disable 'A stable release of a package should not have a prerelease dependency' warning globally -->
<!-- The "pack" command under 'buildCrossTargeting' for 'Microsoft.DotNet.MSBuildSdkResolver' throws a "NU5104" warning/error while using a "2.1.300" stage0 SDK. For: Linux-x64, Linux-arm, and Linux-arm64 -->
<NoWarn>NU1701;NU5104</NoWarn>

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
Expand Down