Add support for DateOnly and TimeOnly on .Net 6 (#1732). #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* Add support of IPAddress and IPEndpoint arguments * IPEndPoint.TryParse isn't supported until .Net 7 * TryParse should work from .Net Core >= 3.1 * Add missing [Fact] attributes * Remove nullable IPAddress/IPEndPoint tests
jonsequitur
reviewed
May 10, 2022
| @@ -96,7 +110,7 @@ internal static partial class ArgumentConverter | |||
|
|
|||
| [typeof(FileSystemInfo)] = (string path, out object? value) => | |||
| { | |||
| if (String.IsNullOrEmpty(path)) | |||
| if (string.IsNullOrEmpty(path)) | |||
There was a problem hiding this comment.
Good call on this change.
jonsequitur
approved these changes
May 10, 2022
|
Could you please rebase this? |
I tried but I think I messed up somewhere? Should I close this PR and create a new? |
Did it work @jonsequitur ? I hope you didn't have too much work with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
DateOnlyandTimeOnlydata types in theArgumentConverter.