Skip to content

Add support for IPAddress and IPEndpoint arguments #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2022
Merged

Add support for IPAddress and IPEndpoint arguments #1735

merged 5 commits into from
May 9, 2022

Conversation

RobThree
Copy link
Contributor

@RobThree RobThree commented May 9, 2022

As in #1734, but this time for IPAddress and IPEndpoint, both common types I find myself passing to commandline utilities.

@jonsequitur
Copy link
Contributor

Thanks, @RobThree!

@RobThree RobThree marked this pull request as draft May 9, 2022 22:28
@RobThree RobThree changed the title Add support of IPAddress and IPEndpoint arguments Add support for IPAddress and IPEndpoint arguments May 9, 2022
@RobThree RobThree marked this pull request as ready for review May 9, 2022 23:00
@jonsequitur jonsequitur merged commit 1ac7dfd into dotnet:main May 9, 2022
@RobThree RobThree deleted the ipaddress-and-ipendpoint branch May 9, 2022 23:58
@RobThree
Copy link
Contributor Author

Thanks @jonsequitur! 🎉

Could you maybe also have a look at (or maybe provide some feedback on) #1734 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobThree @jonsequitur