Skip to content

Add HttpClient guidance #29568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2022
Merged

Add HttpClient guidance #29568

merged 7 commits into from
May 23, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 20, 2022

@gewarren gewarren requested a review from karelz May 20, 2022 21:28
@gewarren gewarren marked this pull request as ready for review May 20, 2022 21:28
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready. There are two suggestions I'd like to see incorporated before this is merged.

@gewarren gewarren enabled auto-merge (squash) May 23, 2022 16:10
@gewarren gewarren merged commit 79a0b52 into dotnet:main May 23, 2022
@Henderv
Copy link

Henderv commented Jun 13, 2022

Fixes #26510.

Preview link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient - items to improve
5 participants