Skip to content

Add Sysytem.Net.* missing API #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 23, 2020
Merged

Add Sysytem.Net.* missing API #4904

merged 6 commits into from
Sep 23, 2020

Conversation

aik-jahoda
Copy link
Contributor

Summary

Add Sysytem.Net.* missing API

cc: @carlossanlop

@aik-jahoda aik-jahoda requested review from gewarren and a team September 23, 2020 11:07
@opbld34
Copy link

opbld34 commented Sep 23, 2020

Docs Build status updates of commit bd8da72:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Net.Sockets/TcpClient.xml ❌Error Details
❌Error Details

xml/System.Net.Sockets/TcpClient.xml

  • Line 0, Column 0: [Error-ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Member' start tag on line 1328 position 6 does not match the end tag of 'Docs'. Line 1381, position 9.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

  • Line 0, Column 0: [Error-ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...
  • Line 0, Column 0: [Error-file-not-found] Invalid file link: '.sourcemap-ecma-0.json'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

CarnaViire
CarnaViire reviewed Sep 23, 2020
View reviewed changes
xml/System.Net.Http/SocketsHttpHandler.xml Outdated
<summary>To be added.</summary>
<value>To be added.</value>
<remarks>To be added.</remarks>
<summary>Gets or sets the keep alive ping delay. The client will send a keep alive ping to the server if it doesn't receive any frames on a connection for this period of time. This property is used together with <see cref="System.Net.Http.SocketsHttpHandler.KeepAlivePingTimeout"/> to close broken connections.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but maybe it will sound a bit more clear if we say This property is used together with <see cref="System.Net.Http.SocketsHttpHandler.KeepAlivePingTimeout"/> to check whether the connection is broken.?

@aik-jahoda aik-jahoda force-pushed the jajahoda/networking-last-RC2-pieces branch from bd8da72 to 7e1a6ab Compare September 23, 2020 13:26
@opbld32
Copy link

opbld32 commented Sep 23, 2020

Docs Build status updates of commit 7e1a6ab:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/SocketsHttpHandler.xml ⚠️Warning View Details
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

xml/System.Net.Http/SocketsHttpHandler.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Timeout.InfiniteTimeSpan'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Sep 23, 2020

Docs Build status updates of commit 8c0df13:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/SocketsHttpHandler.xml ⚠️Warning View Details
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

xml/System.Net.Http/SocketsHttpHandler.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Timeout.InfiniteTimeSpan'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

alnikola
alnikola approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@alnikola alnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My APIs are good.

carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
@opbld34
Copy link

opbld34 commented Sep 23, 2020

Docs Build status updates of commit c7362f8:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/SocketsHttpHandler.xml ⚠️Warning View Details
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

xml/System.Net.Http/SocketsHttpHandler.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Timeout.InfiniteTimeSpan'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"T:System.Threading.Timeout.InfiniteTimeSpan"/'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay*"/'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
@opbld30
Copy link

opbld30 commented Sep 23, 2020

Docs Build status updates of commit dc17490:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Http/SocketsHttpHandler.xml ⚠️Warning View Details
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

xml/System.Net.Http/SocketsHttpHandler.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: '"P:System.Net.Http.SocketsHttpHandler.KeepAlivePingDelay"/'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

carlossanlop
carlossanlop reviewed Sep 23, 2020
View reviewed changes
@opbld31
Copy link

opbld31 commented Sep 23, 2020

Docs Build status updates of commit 8ce120a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View
xml/System.Net.Http/SocketsHttpHandler.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 2d73781 into dotnet:net5-rc2 Sep 23, 2020
@carlossanlop carlossanlop deleted the jajahoda/networking-last-RC2-pieces branch September 23, 2020 19:15
gewarren pushed a commit to gewarren/dotnet-api-docs that referenced this pull request Sep 24, 2020
@carlossanlop @gewarren
Add Sysytem.Net.* missing API (dotnet#4904)
f6775a5 
* System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections

* Add Sysytem.Net.\* missing API

* Apply PR comments

* Apply suggestions from code review

* Apply suggestions from code review

* Update xml/System.Net.Http/SocketsHttpHandler.xml

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
carlossanlop added a commit that referenced this pull request Sep 24, 2020
@carlossanlop @tarekgh
@gewarren @jozkee @buyaa-n @bartonjs @aik-jahoda @ManickaP @Anipik
Rc2 doc comments (#4908)
0ae4e98 
* Automatic port of System.OperatingSystem docs for RC2 (#4852)

Co-authored-by: carlossanlop <[email protected]>

* Add Missing System.Diagnostics docs (#4856)

* Add Missing System.Diagnostics docs

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

Co-authored-by: Carlos Sanchez <[email protected]>

* Automatically port System.Diagnostics docs for RC2 (#4853)

* Automatically port System.Diagnostics docs for RC2

* Update xml/System.Diagnostics/ActivitySamplingResult.xml

Co-authored-by: Carlos Sanchez <[email protected]>

* Update xml/System.Diagnostics/Process.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>

* Automatic port of RegexParse* documentation (#4850)

* Automatic port of RegexParse* documentation

* Update xml/System.Text.RegularExpressions/RegexParseError.xml

* Apply suggestions from code review

* Update RegexParseException

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>

* Add ssl API added between preview 7 and 8 (#4860)

* Automatic port of Reflection RC2 documentation (#4851)

* Revert "Add ssl API added between preview 7 and 8 (#4860)" (#4868)

This reverts commit 10d2b88.

* Add ssl API added between preview 7 and 8 #2 (#4869)

* Add ssl API added between preview 7 and 8

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

* Update xml/System.Net.Security/SslStream.xml

* Apply @wfurt comments

* Add missing remark headers

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback (#4861)

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback

* Apply PR comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Add a remark to AddEvent method (#4871)

* Add a remark to AddEvent method

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Genevieve Warren <[email protected]>

* Automatic port of CryptoStream docs (#4888)

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of System.Buffers docs (#4882)

Co-authored-by: carlossanlop <[email protected]>

* resolve isprefix conflict

* Automatic port of System.Data.Common docs (#4885)

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of *PipeServerStreamAcl docs (#4880)

* Automatic port of *PipeServerStreamAcl docs

* Apply suggestions from code review

Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: David Cantú <[email protected]>

* Automatic port of *OSPlatformAttribute docs (#4883)

* Automatic port of *OSPlatformAttribute docs

* Missing TargetPlatformAttribute constructor parameter description.

* Apply suggestions from code review

Co-authored-by: Buyaa <[email protected]>

* Update xml/System.Runtime.Versioning/SupportedOSPlatformAttribute.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Buyaa <[email protected]>

* Document System.Enum (#4894)

Co-authored-by: carlossanlop <[email protected]>

* Document Half.op_Explicit APIs (#4893)

* Document Half.op_Explicit APIs

* Equals

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of Rune.CompareTo EII (#4891)

Co-authored-by: carlossanlop <[email protected]>

* Add missing docs for AsnContentException. (#4895)

* Add missing documentation for S.S.Cryptography (#4892)

* Add missing documentation for S.S.Cryptography

* Apply feedback

* Automatic port of System.Threading.ExecutionContext.Restore doc (#4887)

* Automatic port of System.Threading.ExecutionContext.Restore doc

* Update xml/System.Threading/ExecutionContext.xml

Co-authored-by: Prashanth Govindarajan <[email protected]>

* Apply suggestions from code review

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>

* Automatic port of  explicit interface implementation of System.Net.Http.HttpRequestOptions (#4881)

* Automatic port of explicit interface implementations for System.Net.Http.HttpRequestOptions

* Apply suggestions from code review

Co-authored-by: Jan Jahoda <[email protected]>

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>

* Document Type.IsAssignableTo (#4898)

Co-authored-by: carlossanlop <[email protected]>

* Document System.PlatformID.Other (#4897)

Co-authored-by: carlossanlop <[email protected]>

* HTTP Version Selection (#4870)

* Sync docs with source comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Add values

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* HttpClient sync operations (#4776)

* Draft for @ManickaP

* Apply suggestions from code review

Co-authored-by: Marie Píchová <[email protected]>

* Format verification

* Format verification

* Fix links

* Fix links

* Fix xml tag

* Fix links

* Fix links

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* Fix links

* Add CreateContentReadStream

* Fix links

* Add System.Net.Http.DelegatingHandler.Send

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* Remove "Synchronous" information from summary

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* Fix the  exception description

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Marie Píchová <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* adding docs for missing 5.0 apis for system.Runtime.CompilerServices.Unsafe  (#4902)

* adding docs for missing 5.0 apis

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* resolve conflict

* Add Sysytem.Net.* missing API (#4904)

* System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections

* Add Sysytem.Net.\* missing API

* Apply PR comments

* Apply suggestions from code review

* Apply suggestions from code review

* Update xml/System.Net.Http/SocketsHttpHandler.xml

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* Http sync follow up (#4905)

* Add the http sync follow up

* Fix closing tag

Co-authored-by: Jan Jahoda <[email protected]>

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: Buyaa <[email protected]>
Co-authored-by: Jeremy Barton <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Marie Píchová <[email protected]>
Co-authored-by: Anirudh Agnihotry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop left review comments

@CarnaViire CarnaViire CarnaViire left review comments

@alnikola alnikola alnikola approved these changes

@gewarren gewarren Awaiting requested review from gewarren

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aik-jahoda @opbld34 @opbld32 @opbld33 @opbld30 @opbld31 @carlossanlop @CarnaViire @alnikola @eiriktsarpalis