Http sync follow up #4905

aik-jahoda · 2020-09-23T19:25:34Z

Summary

Follow up of #4776

opbld33 · 2020-09-23T19:28:03Z

Docs Build status updates of commit ecd28b1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClient.xml	❌Error		Details
	❌Error		Details

xml/System.Net.Http/HttpClient.xml

Line 0, Column 0: [Error-ECMA2Yaml_InternalError]

Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 2781 position 8 does not match the end tag of 'remarks'. Line 2787, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

Line 0, Column 0: [Error-ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...
Line 0, Column 0: [Error-file-not-found] Invalid file link: '.sourcemap-ecma-0.json'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

carlossanlop

LGTM! Thanks for submitting.

carlossanlop · 2020-09-23T19:28:50Z

Closing and reopening to re-trigger the CI.

ManickaP

LGTM, thank you for the fixes.

opbld31 · 2020-09-23T19:31:28Z

Docs Build status updates of commit ecd28b1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClient.xml	❌Error		Details
	❌Error		Details

xml/System.Net.Http/HttpClient.xml

Line 0, Column 0: [Error-ECMA2Yaml_InternalError]

Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 2781 position 8 does not match the end tag of 'remarks'. Line 2787, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

Line 0, Column 0: [Error-ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...
Line 0, Column 0: [Error-file-not-found] Invalid file link: '.sourcemap-ecma-0.json'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

opbld31 · 2020-09-23T19:53:01Z

Docs Build status updates of commit d6bfcc6:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Net.Http/ByteArrayContent.xml	✅Succeeded	View
xml/System.Net.Http/DelegatingHandler.xml	✅Succeeded	View
xml/System.Net.Http/HttpClient.xml	✅Succeeded	View
xml/System.Net.Http/HttpClientHandler.xml	✅Succeeded	View
xml/System.Net.Http/HttpContent.xml	✅Succeeded	View
xml/System.Net.Http/HttpMessageHandler.xml	✅Succeeded	View
xml/System.Net.Http/HttpMessageInvoker.xml	✅Succeeded	View
xml/System.Net.Http/MessageProcessingHandler.xml	✅Succeeded	View
xml/System.Net.Http/MultipartContent.xml	✅Succeeded	View
xml/System.Net.Http/ReadOnlyMemoryContent.xml	✅Succeeded	View
xml/System.Net.Http/StreamContent.xml	✅Succeeded	View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

* Add the http sync follow up * Fix closing tag Co-authored-by: Jan Jahoda <[email protected]>

@wfurt

* Automatic port of System.OperatingSystem docs for RC2 (#4852) Co-authored-by: carlossanlop <[email protected]> * Add Missing System.Diagnostics docs (#4856) * Add Missing System.Diagnostics docs * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Automatically port System.Diagnostics docs for RC2 (#4853) * Automatically port System.Diagnostics docs for RC2 * Update xml/System.Diagnostics/ActivitySamplingResult.xml Co-authored-by: Carlos Sanchez <[email protected]> * Update xml/System.Diagnostics/Process.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]> * Automatic port of RegexParse* documentation (#4850) * Automatic port of RegexParse* documentation * Update xml/System.Text.RegularExpressions/RegexParseError.xml * Apply suggestions from code review * Update RegexParseException * Update xml/System.Text.RegularExpressions/RegexParseException.xml * Update xml/System.Text.RegularExpressions/RegexParseException.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> * Add ssl API added between preview 7 and 8 (#4860) * Automatic port of Reflection RC2 documentation (#4851) * Revert "Add ssl API added between preview 7 and 8 (#4860)" (#4868) This reverts commit 10d2b88. * Add ssl API added between preview 7 and 8 #2 (#4869) * Add ssl API added between preview 7 and 8 * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Update xml/System.Net.Security/SslStream.xml * Apply @wfurt comments * Add missing remark headers * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback (#4861) * Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback * Apply PR comments * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add a remark to AddEvent method (#4871) * Add a remark to AddEvent method * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Automatic port of CryptoStream docs (#4888) Co-authored-by: carlossanlop <[email protected]> * Automatic port of System.Buffers docs (#4882) Co-authored-by: carlossanlop <[email protected]> * resolve isprefix conflict * Automatic port of System.Data.Common docs (#4885) Co-authored-by: carlossanlop <[email protected]> * Automatic port of *PipeServerStreamAcl docs (#4880) * Automatic port of *PipeServerStreamAcl docs * Apply suggestions from code review Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review * Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml * Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: David Cantú <[email protected]> * Automatic port of *OSPlatformAttribute docs (#4883) * Automatic port of *OSPlatformAttribute docs * Missing TargetPlatformAttribute constructor parameter description. * Apply suggestions from code review Co-authored-by: Buyaa <[email protected]> * Update xml/System.Runtime.Versioning/SupportedOSPlatformAttribute.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Buyaa <[email protected]> * Document System.Enum (#4894) Co-authored-by: carlossanlop <[email protected]> * Document Half.op_Explicit APIs (#4893) * Document Half.op_Explicit APIs * Equals Co-authored-by: carlossanlop <[email protected]> * Automatic port of Rune.CompareTo EII (#4891) Co-authored-by: carlossanlop <[email protected]> * Add missing docs for AsnContentException. (#4895) * Add missing documentation for S.S.Cryptography (#4892) * Add missing documentation for S.S.Cryptography * Apply feedback * Automatic port of System.Threading.ExecutionContext.Restore doc (#4887) * Automatic port of System.Threading.ExecutionContext.Restore doc * Update xml/System.Threading/ExecutionContext.xml Co-authored-by: Prashanth Govindarajan <[email protected]> * Apply suggestions from code review Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> * Automatic port of explicit interface implementation of System.Net.Http.HttpRequestOptions (#4881) * Automatic port of explicit interface implementations for System.Net.Http.HttpRequestOptions * Apply suggestions from code review Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> * Document Type.IsAssignableTo (#4898) Co-authored-by: carlossanlop <[email protected]> * Document System.PlatformID.Other (#4897) Co-authored-by: carlossanlop <[email protected]> * HTTP Version Selection (#4870) * Sync docs with source comments * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add values Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * HttpClient sync operations (#4776) * Draft for @ManickaP * Apply suggestions from code review Co-authored-by: Marie Píchová <[email protected]> * Format verification * Format verification * Fix links * Fix links * Fix xml tag * Fix links * Fix links * Fix links * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * Fix links * Add CreateContentReadStream * Fix links * Add System.Net.Http.DelegatingHandler.Send * Fix links * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * Remove "Synchronous" information from summary * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Fix the exception description Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Marie Píchová <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * adding docs for missing 5.0 apis for system.Runtime.CompilerServices.Unsafe (#4902) * adding docs for missing 5.0 apis * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * resolve conflict * Add Sysytem.Net.* missing API (#4904) * System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections * Add Sysytem.Net.\* missing API * Apply PR comments * Apply suggestions from code review * Apply suggestions from code review * Update xml/System.Net.Http/SocketsHttpHandler.xml Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Http sync follow up (#4905) * Add the http sync follow up * Fix closing tag Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: David Cantú <[email protected]> Co-authored-by: Buyaa <[email protected]> Co-authored-by: Jeremy Barton <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Marie Píchová <[email protected]> Co-authored-by: Anirudh Agnihotry <[email protected]>

Add the http sync follow up

ecd28b1

aik-jahoda mentioned this pull request Sep 23, 2020

HttpClient sync operations #4776

Merged

carlossanlop approved these changes Sep 23, 2020

View reviewed changes

carlossanlop closed this Sep 23, 2020

carlossanlop reopened this Sep 23, 2020

ManickaP approved these changes Sep 23, 2020

View reviewed changes

Fix closing tag

d6bfcc6

carlossanlop merged commit b4bd52b into dotnet:net5-rc2 Sep 23, 2020

carlossanlop deleted the jahoda/httpsync-followup branch September 23, 2020 20:03

gewarren pushed a commit to gewarren/dotnet-api-docs that referenced this pull request Sep 24, 2020

Http sync follow up (dotnet#4905)

1baf681

* Add the http sync follow up * Fix closing tag Co-authored-by: Jan Jahoda <[email protected]>

eiriktsarpalis added the area-System.Net.Http label Mar 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Http sync follow up #4905

Http sync follow up #4905

Uh oh!

aik-jahoda commented Sep 23, 2020

Uh oh!

opbld33 commented Sep 23, 2020

Uh oh!

carlossanlop left a comment

Uh oh!

carlossanlop commented Sep 23, 2020

Uh oh!

ManickaP left a comment

Uh oh!

opbld31 commented Sep 23, 2020

Uh oh!

opbld31 commented Sep 23, 2020

Uh oh!

Uh oh!

Http sync follow up #4905

Http sync follow up #4905

Uh oh!

Conversation

aik-jahoda commented Sep 23, 2020

Summary

Uh oh!

opbld33 commented Sep 23, 2020

❌ Validation status: errors

xml/System.Net.Http/HttpClient.xml

Uh oh!

carlossanlop left a comment

Choose a reason for hiding this comment

Uh oh!

carlossanlop commented Sep 23, 2020

Uh oh!

ManickaP left a comment

Choose a reason for hiding this comment

Uh oh!

opbld31 commented Sep 23, 2020

❌ Validation status: errors

xml/System.Net.Http/HttpClient.xml

Uh oh!

opbld31 commented Sep 23, 2020

✅ Validation status: passed

Uh oh!

Uh oh!