Skip to content

Names -> Keywords batch 8 #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WhiteBlackGoose
Copy link
Contributor

Replacing full type names with keywords when appropriate

Files affected: BadSearch.cs, EmptyString1.cs, Enumerator1.cs, FindWords1.cs, NoElements.cs, NoFind1.cs, NoFind2.cs, OOR1.cs, OOR2.cs, Race1.cs.

See #6920

Replacing full type names with keywords when appropriate

Files affected: BadSearch.cs, EmptyString1.cs, Enumerator1.cs, FindWords1.cs, NoElements.cs, NoFind1.cs, NoFind2.cs, OOR1.cs, OOR2.cs, Race1.cs.

See dotnet#6920
@ghost ghost added the area-System.Runtime label Jul 26, 2021
@opbld33
Copy link

opbld33 commented Jul 26, 2021

Docs Build status updates of commit 2815b41:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@WhiteBlackGoose WhiteBlackGoose marked this pull request as ready for review July 26, 2021 10:10
@WhiteBlackGoose WhiteBlackGoose requested a review from a team as a code owner July 26, 2021 10:10
@opbld34
Copy link

opbld34 commented Jul 26, 2021

Docs Build status updates of commit be900e3:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/BadSearch.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/EmptyString1.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/Enumerator1.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/FindWords1.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/NoElements.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/NoFind1.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/NoFind2.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/OOR1.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/OOR2.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/System.ArgumentOutOfRangeException/cs/Race1.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit 5f55fbb into dotnet:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants