Investigate.nuget

[KevinRansom]

Fixes #18231 #r nuget ..." downloads unneeded packages.

What happens is, when typechecking in the ide, we try to fetch nuget packages after every key stroke, which is obviously not great because it means when typing #r "nuget: fsharp.data" we will go and fetch the f package from nuget.org, as well as fs and fsh.

This is clearly not ideal, this fix will not submit a #r nuget packagemanager line if the input caret is still on the line with #r "nuget:blah".

To cause the line to be submitted, the user must either move focus to a different window, or move the input caret to a different line. In my testing locally this actually works really well, it's probably pretty much what I think you would naively expect.

Quickinfo hovertext, is disabled if the packagemanager line has not yet been submitted. After submission, it should show the resolved .dll path.

There is one more delta in this fix, unrelated to the IDE, but part of this fix. The change is that by default, when we resolve nuget packages we disable package based build targets by adding: ExcludeAssets='build;buildTransitive;buildMultitargeting' to the package reference.

Most netsdk nuget packages do not need the build targets to execute during restore, which is our primary goal with #r nuget. And so this should be a neutral change. For those packages which must have their build targets executed during restore, this PR adds a new control to #r nuget, usepackagetargets=true.

For example:

#r "nuget:fsharp.data"

generates this:

<ItemGroup><PackageReference Include='fsharp.data' Version='*' ExcludeAssets='build;buildTransitive;buildMultitargeting' /></ItemGroup>

and

#r "nuget:fsharp.data, usepackagetargets=true"
generates this:
<ItemGroup><PackageReference Include='fsharp.data' Version='*'  /></ItemGroup>

I still need to add test cases for the usepackagetargets=true

It should be noted that: the contents of the "nuget: blah" is not part of the language specification for F#, package managers are an extension, hence the not at all F# nature of the syntax.

The public FCS API on the checker: GetProjectOptionsFromScript and GetProjectSnapshotFromScript

Has an additional optional argument: caret: Position

If it is present then the Position argument is the location of the caret in the ISourceText buffer.
If it is omitted then the old behavior occurs.

Online docs updated here: dotnet/docs#45467
to

/cc @baronfel , @vzarytovskii , @T-Gro

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.300.md
vsintegration/src	docs/release-notes/.VisualStudio/17.14.md

[T-Gro]

cc: @auduchinok , @TheAngryByrd , @baronfel :

One part of this change is a tooling heuristics to postpone downloads of packages from #r "nuget: ... while the caret is on the same line. This PR makes the caret position an optional part of the public API for script checking, so that you can decide about implementing the same for script design-time scenario in Ionide/Rider as well.

Passing in None will keep existing behavior of downloading packages while typing.

[TheAngryByrd]

Originally we had some code that tried to do this, good to see it’s built in now!

[NatElkins]

Will this still play nicely with things like FAKE scripts?

https://fake.build/guide/getting-started.html#Run-FAKE-using-the-FAKE-runner

[T-Gro]

Will this still play nicely with things like FAKE scripts?

https://fake.build/guide/getting-started.html#Run-FAKE-using-the-FAKE-runner

If the mentioned Fake package relies on custom build props/targets shipped with package, it will need the additional syntax for allowing that, this PR does think of that.