document model API improvements #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
documents-package-improvements
branch
from
ed7150e to
408acca
Compare
brettfo
reviewed
Jul 2, 2022
| @@ -23,10 +21,8 @@ static Serializer() | |||
| NumberHandling = JsonNumberHandling.AllowReadingFromString | JsonNumberHandling.AllowNamedFloatingPointLiterals, | |||
| Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping | |||
| }; | |||
| JsonSerializerOptions.Converters.Add(new ByteArrayConverter()); | |||
There was a problem hiding this comment.
We need to keep this. When a notebook is saved it's sent back as a byte array, but serialized as a base64 string.
There was a problem hiding this comment.
This is in Microsoft.DotNet.Interactive, not Microsoft.DotNet.Interactive.Documents. I removed the reference from the former to the latter. I assume the only case where we need this is here?
jonsequitur
force-pushed
the
documents-package-improvements
branch
4 times, most recently
from
9444a83 to
8159c62
Compare
jonsequitur
changed the title
jonsequitur
force-pushed
the
documents-package-improvements
branch
from
e20460a to
263d4f0
Compare
jonsequitur
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Microsoft.DotNet.Interactive.Documents API to more closely follow the
.ipynbspec and observed behavior in Jupyter Lab. It also makes more concepts explicit in the API and makes it mutable so that creating documents incrementally is easier.This addresses #2148.