Fix BoxView not rendering when is hidden on start#21960
Merged
Conversation
Contributor
|
/azp run |
jsuarezruiz
added
the
legacy-area-controls
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Apr 22, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Apr 23, 2024
| propertyName == CornerRadiusProperty.PropertyName) | ||
| Handler?.UpdateValue(nameof(IShapeView.Shape)); | ||
|
|
||
| if(propertyName == IsVisibleProperty.PropertyName) |
Contributor
Author
There was a problem hiding this comment.
Strangely enough, it is only necessary for Android. For iOS everything works with only updating Handler?.UpdateValue(nameof(IShapeView.Shape)); when the visibility changes
jsuarezruiz
reviewed
Apr 24, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
added
area-layout
Contributor
Contributor
|
/rebase |
github-actions
Bot
force-pushed
the
boxview-hotfix
branch
from
ea05f07 to
60a5b87
Compare
Contributor
|
/rebase |
github-actions
Bot
force-pushed
the
boxview-hotfix
branch
from
60a5b87 to
2e3f3c9
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously requested changes
Nov 12, 2024
jsuarezruiz
left a comment
jsuarezruiz
left a comment
Contributor
There was a problem hiding this comment.
The test PropertiesShouldBeCorrectlyApplied is failing on Android with the changes:
Added a sample to UITest Update BoxView.cs Update Issue19926.cs
kubaflo
force-pushed
the
boxview-hotfix
branch
from
2e3f3c9 to
93dc202
Compare
Contributor
Author
Yea, I've modified this test and was waiting for the snapshot. It will work now :) |
Contributor
Author
|
@jsuarezruiz could you /azp pls? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Dec 6, 2024
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
I observed that the BoxView did appear on the screen when the user changed the property
IsVisiblefrom false to true whenIsVisible = falsewas set on the start.This is a hotfix to this PR: #21322
before.mp4
fix.mp4