Skip to content

Fix BoxView not rendering when is hidden on start #21960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Dec 6, 2024
Merged

Fix BoxView not rendering when is hidden on start #21960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd4e0f3
Update BoxView.cs
kubaflo Apr 22, 2024
93dc202
Updated screenshot
kubaflo Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Controls/src/Core/BoxView/BoxView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ protected override void OnPropertyChanged([CallerMemberName] string? propertyNam

if (propertyName == BackgroundColorProperty.PropertyName ||
propertyName == ColorProperty.PropertyName ||
propertyName == IsVisibleProperty.PropertyName ||
Comment thread
kubaflo marked this conversation as resolved.
propertyName == BackgroundProperty.PropertyName ||
propertyName == CornerRadiusProperty.PropertyName)
Handler?.UpdateValue(nameof(IShapeView.Shape));
Expand Down
Binary file modified ...estCases.Android.Tests/snapshots/android/PropertiesShouldBeCorrectlyApplied.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,17 @@
<Label HorizontalTextAlignment="Center" Text="Scale X"/>
<BoxView ScaleX="1.5"/>
</StackLayout>

<StackLayout>
<Button
Text="Click to show a BoxView"
Clicked="Button_Clicked"
AutomationId="button"/>
<BoxView
x:Name="boxView"
AutomationId="boxView2"
HorizontalOptions="Center"
IsVisible="False"/>
</StackLayout>
</StackLayout>
</ContentPage>
5 changes: 5 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,9 @@ public Issue19926()
{
InitializeComponent();
}

void Button_Clicked(object sender, System.EventArgs e)
{
boxView.IsVisible = true;
}
}
6 changes: 5 additions & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19926.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@ public Issue19926(TestDevice device)

[Test]
[Category(UITestCategories.BoxView)]
public void PropertiesShouldBeCorrectlyApplied()
public async Task PropertiesShouldBeCorrectlyApplied()
{
_ = App.WaitForElement("boxView");
App.Click("button");
_ = App.WaitForElement("boxView2");

// A small delay to wait for the button ripple effect animation to complete.
await Task.Delay(500);
VerifyScreenshot();
}
}
Expand Down