-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Support W3C Propagator #114583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support W3C Propagator #114583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj: Language not supported
- src/libraries/System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj: Language not supported
src/libraries/System.Diagnostics.DiagnosticSource/tests/PropagatorTests.cs
Show resolved
Hide resolved
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
@MihaZupan @antonfirsov we are changing the default propagator to use the new W3C one instead of the legacy one. Looks like many http/socket tests are failing because of that. Could you please help by looking at the failed tests and fix these? The new W3C propagator is not supporting If want to continue testing hierarchical activity ids, you can consider reset the current propagator to the legacy one. We haven't exposed API to return that yet, but the test can use reflection if want to. Let me know and I can help. |
CC @JamesNK for awareness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions inline but other than that LGTM!
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/W3CPropagator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/W3CPropagatorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/tests/W3CPropagatorTests.cs
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/W3CPropagator.cs
Show resolved
Hide resolved
Does ASP.NET Core need to do anything to read headers added to requests? Or does it already work? |
aspnet core support both header names |
Contribute to #103174
DistributedContextPropagator.Current
andDistributedContextPropagator.CreateDefaultPropagator()
now will have the W3C Propagator as the default propagator.DistributedContextPropagator.CreateLegacyPropagator()
to allow user to opt-in to the legacy propagator.