Skip to content

Conversation

@elinor-fung
Copy link
Member

Follow-up for #116658 (comment)

Split the MultipleHives tests into a regular FrameworkResolution and a Windows-only MultilevelLookup class.

This also reduces the amount of tests we run against multi-level lookup:

  • Reduce number of tested TFMs < 7.0 to just netcoreapp3.1 and net6.0
  • Remove test for --fx-version - we have the non-multi-level lookup coverage and multi-level lookup does add a particularly interesting dimension

cc @dotnet/appmodel @AaronRobinsonMSFT

Copilot AI review requested due to automatic review settings June 24, 2025 23:02
@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Host labels Jun 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits the MultipleHives tests into two separate classes to clearly separate regular framework resolution tests from Windows-only multi-level lookup tests and reduces the total number of multi-level lookup scenarios. Key changes include:

  • Removal of the MultipleHives tests.
  • Introduction of a dedicated Windows-only MultilevelLookup test class.
  • Refactoring of the shared test base and RunTest methods in FrameworkResolutionBase to support the new design.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
MultipleHives.cs Removal of the old tests, now split into separated classes.
MultilevelLookup.cs New Windows-only test class for multi-level lookup scenarios.
FrameworkResolutionBase.cs Refactored RunTest method to streamline command construction.
FrameworkResolution.cs New test class handling regular framework resolution logic.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit 19a01d0 into dotnet:main Jul 7, 2025
77 of 79 checks passed
@elinor-fung elinor-fung deleted the multilevelLookup-test-cleanup branch July 7, 2025 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Host test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants