Skip to content

[mono] Fix r8->i conversion on amd64. #64467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jan 28, 2022

Fixes #64386.

@lambdageek

This comment has been minimized.

@vargaz vargaz merged commit 8471eec into dotnet:main Jan 29, 2022
@vargaz vargaz deleted the fix-fconv-to-i branch January 29, 2022 01:50
@lambdageek
Copy link
Member

@vargaz should we backport this to 6.0?

@vargaz
Copy link
Contributor Author

vargaz commented Jan 31, 2022

We should

@am11
Copy link
Member

am11 commented Feb 7, 2022

@vargaz, is this failure related https://helix.dot.net/api/2019-06-17/jobs/a5963b9d-9f2a-495e-8451-7569cebe9bd4/workitems/System.Runtime.InteropServices.Tests/console:

    System.Runtime.InteropServices.Tests.NFloatTests.NFloatToIntPtr(value: 0) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   4393751543808
      Stack Trace:
        /_/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.cs(483,0): at System.Runtime.InteropServices.Tests.NFloatTests.NFloatToIntPtr(Single value)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.Mono.cs(386,0): at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object obj, BindingFlags invokeAttr, Span`1 parameters)
    System.Runtime.InteropServices.Tests.NFloatTests.NFloatToIntPtr(value: 4567) [FAIL]

@lambdageek
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1843163912

@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono incorrectly handles conversion of negative doubles to nint
3 participants