Skip to content

Turn off -ffp-contract on Unix #64847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Turn off -ffp-contract on Unix #64847

merged 1 commit into from
Feb 7, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 5, 2022

Fixes #64604

@ghost ghost added area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member labels Feb 5, 2022
@ghost
Copy link

ghost commented Feb 5, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64604

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@am11 am11 marked this pull request as ready for review February 5, 2022 16:28
@am11 am11 requested a review from marek-safar as a code owner February 5, 2022 16:28
@am11
Copy link
Member Author

am11 commented Feb 5, 2022

cc @tannergooding, @lambdageek, applied the option globally to both clang and gcc (in mono's cmake config, the variable GCC is on for gcc and clang as well, which is a bit confusing).

@ghost
Copy link

ghost commented Feb 6, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64604

Author: am11
Assignees: -
Labels:

area-System.Numerics, area-Infrastructure-coreclr, community-contribution
Milestone: -

@jkotas jkotas merged commit 805a5e4 into dotnet:main Feb 7, 2022
@am11 am11 deleted the feature/build/native branch February 7, 2022 17:48
@am11
Copy link
Member Author

am11 commented Feb 7, 2022

Next outerloop run completed, https://github.com/dotnet/runtime/runs/5100686895, seems no failures due to this change, but I am not completely sure about NFloatToIntPtr one: #64467 (comment).

I have opened a few issues for the other failures noticed in the run.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@tannergooding tannergooding tannergooding approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure we set -ffp-contract=off on GCC
4 participants
@am11 @lambdageek @tannergooding @jkotas