fix assert in ssl options clone #72326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71233
The assert we are hitting was added to detect cases when we add new property but we fail to update the clone method.
(it failed that purpose and I added the new missing CertificateChainPolicy as well)
However, in this case it fails because the given
SslClientAuthenticationOptions
is being modified while cloned.While the underlying issue existed for a while I think the recent failures are triggered by #70716.
Registered LocalCertificateSelectionCallback will access Handler's
ClientCertificates
and that will triggerThe tests (like SendMoreThanStreamLimitRequestsConcurrently_LastWaits) triggering the assert use
Parallel.For
to blast bunch of requests, each racing the initialization in chain setup and modifying ClientCertificates fromnull
to empty collection.This fix is to use underlying object without attempt to initialize it and guarding against
null
inGetEligibleClientCertificate
.