Skip to content

Add support for new output path format #31454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Mar 31, 2023

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Mar 24, 2023

This ports the artifacts output support from #29599 to main. This implements the design in dotnet/designs#281.

In addition to porting the code, it also includes the following:

  • De-duplicate ArtifactsPath calculation logic by adding a .props file which can be imported from two different places depending on whether there are any artifacts output properties set in Directory.Build.props (or the command line) or not.
  • Add telemetry to help us understand how and how much the artifacts output format is used.

Still to do:

  • De-duplicate test solution creation code
  • Add hook to MSBuild to inject targets after Directory.Build.props import, and use that in SDK instead of duplicate import logic.

@dsplaisted dsplaisted requested a review from a team as a code owner March 24, 2023 20:06
@dsplaisted dsplaisted requested review from a team as code owners March 24, 2023 20:06
@ghost ghost added the untriaged Request triage from a team member label Mar 24, 2023
@ghost
Copy link

ghost commented Mar 24, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dsplaisted dsplaisted force-pushed the artifacts-output-paths-main branch from cabfdfe to b9b67fb Compare March 26, 2023 13:11
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from the ASP.NET Core perspective look good. Let us know if you need further input from our side

Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port and solution consolidation looks great to me. Thank you for consolidating those. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants