-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for new output path format #31454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new output path format #31454
Conversation
…roperty, and reenable pack tests
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
cabfdfe
to
b9b67fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from the ASP.NET Core perspective look good. Let us know if you need further input from our side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port and solution consolidation looks great to me. Thank you for consolidating those. :)
This ports the artifacts output support from #29599 to main. This implements the design in dotnet/designs#281.
In addition to porting the code, it also includes the following:
ArtifactsPath
calculation logic by adding a .props file which can be imported from two different places depending on whether there are any artifacts output properties set in Directory.Build.props (or the command line) or not.Still to do:
Directory.Build.props
import, and use that in SDK instead of duplicate import logic.