Set PlatformName and other properties early enough in outer build #33003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Forgind
approved these changes
Jun 5, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MiYanni
approved these changes
Jun 6, 2023
Comment on lines
+19
to
+21
| <Configuration Condition="'$(Configuration)'==''">Debug</Configuration> | ||
| <Platform Condition="'$(Platform)'==''">AnyCPU</Platform> | ||
| <PlatformName Condition="'$(PlatformName)' == ''">$(Platform)</PlatformName> |
There was a problem hiding this comment.
nit: ''=='' or '' == ''? Not sure what the standard is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32971
As part of the support for the artifacts output path format (#31454), I moved setting default values for
Configuration,Platform, andPlatformNamefromMicrosoft.NET.DefaultOutputPaths.targetstoMicrosoft.NET.Sdk.BeforeCommon.targets.I missed that
Microsoft.NET.DefaultOutputPaths.targetswas also imported fromMicrosoft.NET.Sdk.BeforeCommonCrossTargeting.targets, so these properties were not defaulted correctly in the outer build anymore. This resulted in theOutputPathfor the outer build having a doubled backslash in it, which impacted NuGet pack scenarios.This copies the defaults for those properties to
Microsoft.NET.Sdk.BeforeCommonCrossTargeting.targets, fixing the issue.