-
Notifications
You must be signed in to change notification settings - Fork 136
Create and publish a MergedManifest for unified builds #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Based on the discussions we had offline, we will implement a task that will be used in two scenarios:
Based on these requirements, the task will do the following
|
For downloading pipeline artifacts, we have two options:
The main advantage with the first approach is that we'd be downloading less amount of data, we'd be taking just what we need. But this approach also has a fatal flaw, we'd download every file individually so, we'd probably exceed our rate limit, which would cause throttling. Because of this we probably shouldn't use this approach. The other approach flaw is that we might run out of space, since it requires downloading an artifact zip, and then unzipping it. We'd just save the packages we need, deleting the reset, and could optimize around download order to minimize this risk |
We don't hit this rate limit when doing our BAR publishing today, so it's quite possible we wouldn't hit it. |
we're going to pause this work for a bit, and pick it up at a later point |
I'm going to move the changes from dotnet/installer#19369 to sdk but I also want to add some tests for the tasks that @dkurepa implemented ( @MichaelSimons I heard there is a limitation on testing the tasks in https://github.com/dotnet/sdk/tree/main/src/SourceBuild/content because of source-build, could you explain why is it a issue? Also is it a good place to test the join verticals functionality in the sdk build as it will be part of the sdk repo now? |
@mmitche in the final pass copying assets to a flat layout is having issues with But I see there is also If we have those files maybe we can just copy the first |
The limitation is there is a lack of infrastructure for this. The tests do not belong in the smoke tests or scenario tests. We need a new test suite for these types of unit tests - see #4244. |
Oh jeez...I'm not sure why we produce those files. Let me dig a bit and see whether I can figure it out. |
Done with dotnet/sdk#43627 |
After we're done with #4198, we'll have a
VerticalManifest
published for each leg. We'll need to use all of these manifests to produce aMergedManifest
, similarly to how we do it currently in individual repos.We'll need to have some custom logic for this, as multiple legs might produce duplicate assets #4157.
The text was updated successfully, but these errors were encountered: