Remove cli patch 11: use package version props to set aspnet version #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseefeld
approved these changes
May 3, 2018
|
@dotnet-bot test OSX10.12 Release please (channel disconnected) |
crummel
approved these changes
May 3, 2018
|
Marked no-merge because it would conflict with the RC-blocking #504, and this PR is only for RTM. |
dagood
force-pushed
the
remove-cli-patch-11
branch
from
c843f9c to
4cb9ed7
Compare
|
@dotnet-bot test OSX10.12 Release |
|
@dotnet-bot test OSX10.12 Release please |
|
@dagood OS X went through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the versions of these packages by adding "fake" package-versions to the PVP:
In CLI, they all reference the same version with static props (before the PVP is imported) so we have to override each one.
Not necessary for RC1, but it seems like a pretty safe patch removal.