Skip to content

Update AspNetCore package version used by CLI to 2.1.0-rc1-30682 #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2018

Conversation

dagood
Copy link
Member

@dagood dagood commented May 3, 2018

Update 2.1.0-preview2-final to 2.1.0-rc1-final.

I'm not sure how well this will work with Microsoft.AspNetCore.All 2.1.0-rc1-final not being released yet.

@dagood dagood requested review from dseefeld, crummel and dleeapho May 3, 2018 17:41
@dagood
Copy link
Member Author

dagood commented May 3, 2018

Looks like it doesn't:

".../build.proj" (default target) (1) ->
".../repos/known-good.proj" (Build target) (13:2) ->
".../repos/cli.proj" (Build target) (5:2) ->
(RepoBuild target) -> 
  .../src/cli/build/sdks/sdks.csproj : error NU1603: sdks depends on Microsoft.NET.Sdk.Razor (>= 2.1.0-rc1-final) but Microsoft.NET.Sdk.Razor 2.1.0-rc1-final was not found. An approximate best match of Microsoft.NET.Sdk.Razor 2.1.0-rtm-30698 was resolved. [.../src/cli/build/RestoreDependency.proj] [.../repos/cli.proj]
  .../src/cli/build/sdks/sdks.csproj : error NU1603: sdks depends on Microsoft.NET.Sdk.Razor (>= 2.1.0-rc1-final) but Microsoft.NET.Sdk.Razor 2.1.0-rc1-final was not found. An approximate best match of Microsoft.NET.Sdk.Razor 2.1.0-rtm-30698 was resolved. [.../src/cli/build/RestoreDependency.proj] [.../repos/cli.proj]
  .../repos/dir.targets(197,5): error MSB3073: The command ".../src/cli/build.sh --stage0 .../Tools/dotnetcli/ /p:NETCoreAppMaximumVersion=99.9 /p:CoreSetupBlobRootUrl=file://.../bin/obj/x64/Release/blobs/ /p:SkipBuildingInstallers=true /p:IncludeNuGetPackageArchive=false /p:IncludeAdditionalSharedFrameworks=false /p:UsePortableLinuxSharedFramework=false /p:IncludeSharedFrameworksForBackwardsCompatibilityTests=false /p:IncludeAspNetCoreRuntime=false /p:IncludeMSBuildSdkResolver=false '/p:CLITargets="Prepare;Compile;Package"' /v:detailed  /p:DotNetPackageVersionPropsPath=.../bin/obj/x64/Release/PackageVersions.props /p:DotNetRestoreSourcePropsPath=.../bin/obj/x64/Release/RestoreSources.props " exited with code 1. [.../repos/cli.proj]

Is Microsoft.NET.Sdk.Razor another non-source-built package we have to get rid of?

@dagood
Copy link
Member Author

dagood commented May 3, 2018

Microsoft.NET.Sdk.Razor is a new dependency in 2.1.0-preview2: dotnet/cli#8537. https://www.nuget.org/packages/Microsoft.NET.Sdk.Razor/2.1.0-preview2-final. It looks like a maintainable prebuilt: targets, props, xaml files: nevermind about removing it. We won't have access to the one with version 2.1.0-rc1-final until rc1 releases, though.

Copy link
Contributor

@dleeapho dleeapho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagood
Copy link
Member Author

dagood commented May 3, 2018

I updated the aspnetcore version to the latest ProdCon build that's available, the idea being that 2.1.0-rc1-30682 will be functionally identical to 2.1.0-rc1-final for the dependencies we have.

@dagood
Copy link
Member Author

dagood commented May 3, 2018

I confirmed with a diff that Microsoft.NET.Sdk.Razor 2.1.0-rc1-final and 2.1.0-rc1-30682 have identical contents except version and bits of nupkg metadata.

@dagood dagood merged commit 192f86e into dotnet:dev/release/2.1 May 4, 2018
@dagood dagood deleted the update-aspnet branch May 4, 2018 00:37
@dagood dagood changed the title Update AspNetCore package version used by CLI to 2.1.0-rc1-final Update AspNetCore package version used by CLI to 2.1.0-rc1-30682 May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants