Skip to content

Update CoreClr, ProdCon to rtm-26515-03, 20180516-07-1693122, respectively (dev/release/2.1) #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dotnet-maestro-bot
Copy link
Contributor

No description provided.

@dagood
Copy link
Member

dagood commented May 16, 2018

There's a 2.1-rtm-specific manifest now, but this came from 2.1 (ongoing) manifest location. Marking no-merge for now. I'm trying an upgrade from the 2.1-rtm manifest to see if there's anything we need to uptake, might submit a PR.

@dagood
Copy link
Member

dagood commented May 16, 2018

The manifests actually have the same commits at the moment (note: different package output version stabilization):

https://github.com/dotnet/versions/blob/79731c509a9d31b921f531ee63c48daa8e0c30d5/build-info/dotnet/product/cli/release/2.1/build.xml
https://github.com/dotnet/versions/blob/79731c509a9d31b921f531ee63c48daa8e0c30d5/build-info/dotnet/product/cli/release/2.1-rtm/build.xml

No need to merge this for RTM, so I think we shouldn't to avoid churn. The cli-migrate change is just to skip a test (we don't run tests) and the ILAsm tool change is an auto-update to latest which isn't necessarily linked to what's used in ProdCon anyway.

@dleeapho
Copy link
Contributor

No need to merge this for RTM, so I think we shouldn't to avoid churn.

Agree no merge.

@dagood dagood removed the no-merge label May 22, 2018
@dagood dagood merged commit b560e5a into dotnet:dev/release/2.1 May 22, 2018
dseefeld pushed a commit that referenced this pull request Jun 5, 2018
* Stabilize CLI. (#565)

* Stabilize CLI.
* Use stable MSBuild.
* Fix MSBuild version to match prodcon build.
* Modify CLI build file to always ignore NU5104

* Add web to smoke-test, with and without dev certs (#539)

* Add web to smoke-test, with and without dev certs

* Only reset caches when a test will run

Avoid conflicting with a hanging process if there's no need to delete the files anyway.

* Fix some minor issues with the bootstrap documentation.

* Update CoreClr, ProdCon to rtm-26515-03, 20180516-07-1693122, respectively (#553)

* Only set DropSuffix to true when UseStableVersions is true

* Update dotnet-dev-certs version

This version needs to be compatible with the current runtime being produced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants