Merge dev/release/2.1 into master #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stabilize CLI. * Use stable MSBuild. * Fix MSBuild version to match prodcon build. * Modify CLI build file to always ignore NU5104
* Add web to smoke-test, with and without dev certs * Only reset caches when a test will run Avoid conflicting with a hanging process if there's no need to delete the files anyway.
crummel
suggested changes
May 25, 2018
repos/cli.proj
Outdated
|
|
||
| <!-- Produce stable versions for RTM only. When https://github.com/dotnet/source-build/issues/550 | ||
| is fixed we will be able to determine this automatically. --> | ||
| <EnvironmentVariables Include="DropSuffix=true" /> |
There was a problem hiding this comment.
I think we decided that master should not be stabilized (#571 (comment)). cc @weshaggard
There was a problem hiding this comment.
Thanks, @crummel. I added a Condition to this line to only set it when UseStableVersions is set.
crummel
approved these changes
May 29, 2018
dseefeld
approved these changes
May 29, 2018
This version needs to be compatible with the current runtime being produced.
|
test CentOS7.1 Tarball Release Fedora 24 and OSX are expected to fail until the CI is updated with the new netci.groovy file. |
|
test RHEL7.2 Unshared Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few changes that went into 2.1 that should be ported to master.