Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Add Transactions to netstandard ref #168

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

weshaggard
Copy link
Member

Fixes #157.

cc @terrajobst @saurabh500 @divega

@marek-safar @akoeplinger can you guys confirm that you have these already in xamarin and they just aren't in our reference platform or will they require work for you guys to add?

@akoeplinger
Copy link
Member

From a quick look most if not all seems to be there on Xamarin, we'd just need to generate the reference .cs for System.Transactions.dll. I'll see if I can do that tomorrow.

@weshaggard
Copy link
Member Author

Thanks @akoeplinger

@weshaggard weshaggard merged commit a68fa7b into dotnet:master Jan 18, 2017
@jimcarley
Copy link

Some things I can imagine NOT being in the Xamarin implementation are

Transaction.EnlistPromotableSinglePhase(IPromotableSinglePhaseNotification promotableSinglePhaseNotification, Guid promoterType)

Transaction.PromoterType
Transaction.GetPromotedToken
Transaction.SetDistributedTransactionIdentifier
TransactionInterop.PromoterTypeDTC

These were added to .NET on 2015-08-07 to support SQL Azure's ability to do distributed transactions between SQL Azure instances without using MSDTC. The reference snapshot for Xamarin may have been take before that.

@akoeplinger
Copy link
Member

@jimcarley correct, I added stubs that throw NotImplementedException for those to Mono yesterday.

@terrajobst
Copy link

@jimcarley @akoeplinger can we implement them in principle? I assume the impl we use is part of reference source.

@akoeplinger
Copy link
Member

@terrajobst they seem to be implemented in corefx already. We'll most likely just replace our implementation with that one.

@jimcarley
Copy link

Yes, they should be able to be implemented in Mono/Xamarin. They are implemented in corefx.

@terrajobst
Copy link

Sounds good. So this wouldn't be a permanent stub.

@weshaggard weshaggard deleted the AddTransactions branch January 21, 2017 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants