Add System.Transactions.dll to Xamarin #169
Conversation
Additionally update net461 System.Data.csproj to include a reference to transactions so the commented out API can be added again.
Thanks do let me know if there are any issues with the additions. |
|
I think this is good to go in. I committed changes for the API differences to Mono yesterday: mono/mono@59af66c, might take a bit to bubble up to the public C9 preview. |
| @@ -2168,7 +2168,7 @@ public abstract partial class DbConnection : System.ComponentModel.Component, Sy | |||
| public abstract void Close(); | |||
| public System.Data.Common.DbCommand CreateCommand() { throw null; } | |||
| protected abstract System.Data.Common.DbCommand CreateDbCommand(); | |||
| //TRANSACTIONS public virtual void EnlistTransaction(System.Transactions.Transaction transaction) { } | |||
There was a problem hiding this comment.
Thanks for getting this one I missed it.
|
I assume you will refresh to address the rest of the baseline file once you get them in on your side? |
|
@weshaggard yep |
|
@weshaggard can we merge this now to avoid conflicts with other PRs? |
|
Yes sorry I wasn't sure if you were ready for this to merge yet. Do you not have merge permission? |
I do, just wasn't sure if I'm allowed to merge it myself 😄 |
|
If I've signed off on the code review feel free to merge :) |
Generates API reference for System.Transactions.dll for all Xamarin platforms.
The API compat shows some differences that we need to fix, the current revision in this PR is generated from our latest public C9 preview. I'll make the changes in Mono and update this repo once a new preview is out.
See #168